From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEC80A04DD; Tue, 20 Oct 2020 12:01:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A79BCBE11; Tue, 20 Oct 2020 12:01:38 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 75BC3BE0B for ; Tue, 20 Oct 2020 12:01:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 7B254764; Tue, 20 Oct 2020 06:01:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Oct 2020 06:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4eXTg+GfTB0MVx9Uo0+20vWlQmlzM+/YtTqlC+aH88U=; b=kFvxWFAexlBJx3AY WyU5KH/o5/AS3MyrmCQCNh2DF/M4UuQDDjqy36BU+ZiSmvK/ZFdK+GFC8o+auPM4 RM+7pxux5G/U8ZEnzF6D1nuZuBPWmrmZqXTgBESqpa2kO0dGSs5Eb49spA902K9F j8BvRLKV8Kzp3baqqBG7zIoP8ZJdwM+zUQ02vf5oJVBAhM+IZ5cXnczmra/+LQOn IKv6gSF9LrMANF3JtVgZaqI3ckLK+oUyDqjkUzX1AVb9hBVTC9I+K5GdEO7Y66wn T7dfRdudfUFcTrYEhHX4yhjMdWC4wjQjFe9QWqYw0F2l3GxONdJj+5M+6do5GT46 i3tSPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4eXTg+GfTB0MVx9Uo0+20vWlQmlzM+/YtTqlC+aH8 8U=; b=H2mi/jOODhGiMw3t1dfauvMYtUff3BH8yJ4xNYhTmOFpbk3nU8H9k6Zer hN7UeU44znv6fs3kscYdn3BuDejVp9qJEY0ZD6VgbmBZzfRjQMuUHocet8DawckJ nygunaA4q7M1TPMeffbEdJifDnWL+GUnF9UZIANgcnubYgTxwY2jcQ1gULbawXJO I239CPF7zJkMwIObm8Xkwb2uwas2tS8FZL5bzP1bVMhpOOEXA8vUlr4Qgu0kLicA vOtLQXBlMS3JIpGUItIeF8h4WHOAOqGBfqpnbDVygWy/+EJTKIaCMgbXpF6b9kba oo5lHe1UEIUUHszjVGqLiP70QHj3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeefgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A0B7B3064682; Tue, 20 Oct 2020 06:01:30 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, bluca@debian.org, Andrew Rybchenko Date: Tue, 20 Oct 2020 12:01:28 +0200 Message-ID: <2818739.BjYUp2x7fl@thomas> In-Reply-To: <20201020083701.GB558@bricha3-MOBL.ger.corp.intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <1932663.AIiTPRDKnh@thomas> <20201020083701.GB558@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 6/8] devtools/test-null: load all drivers from directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2020 10:37, Bruce Richardson: > On Mon, Oct 19, 2020 at 06:58:32PM +0200, Thomas Monjalon wrote: > > 15/10/2020 17:05, Bruce Richardson: > > > Rather than specifying specific drivers in the driver directory to load, we > > > can just pass in the whole driver directory to the "-d" EAL flag, causing > > > all drivers to load. This makes the load of driver independent of any > > > specific driver names. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > --- a/devtools/test-null.sh > > > +++ b/devtools/test-null.sh > > > if ldd $testpmd | grep -q librte_ ; then > > > export LD_LIBRARY_PATH=$build/drivers:$build/lib:$LD_LIBRARY_PATH > > > - libs='-d librte_mempool_ring.so -d librte_pmd_null.so' > > > + libs="-d $build/drivers" > > > > In this case, can we remove $build/drivers from LD_LIBRARY_PATH? > > > I think it's safer to keep it, as some drivers depend upon others, e.g. > many NIC/crypto/etc drivers depend upon pci or vdev bus drivers. Therefore > depending on the order in which the drivers load, they will have unmet > dependencies which will be found by looking in LD_LIBRARY_PATH Yes but this test is only for null PMD so I did the change.