From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id D3B7D201 for ; Fri, 10 Feb 2017 09:35:46 +0100 (CET) Received: by mail-wr0-f182.google.com with SMTP id o16so102329474wra.1 for ; Fri, 10 Feb 2017 00:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=+csrnL0CnnW7Tbv8c/VYefS6mZiMktcYNZeblDuepHo=; b=b4KS8b54lpjglyxiwiT+vaZcS3szAh676LKPsYyAkgIdcnblRM+tO273/LE5HeOS8R 9wSiblzpEvUR1XZAesUlmtWKDIcHnZaIGPrPLYY0WpUm+/DUJ5nUp9b7TfvG0GyI2fx0 VqyN6BOeTzovQNUW8MXSTUwTuudx0mKyIWavgAikz7DqtbbURNz3CB0vE1ZNlCNkSvcX FZWqX6ppQWloc0SjlynBQk50dcxO52d23Yr/0V4uai8UpDjdtZD0vQZPKZvBjH5xyURc 1z7x95W30/GMnvrcsV/4IexciSrXF0570mGaeYR/C/PL0MZHOWqxU3TgGnj6QOmISrJ8 v2zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+csrnL0CnnW7Tbv8c/VYefS6mZiMktcYNZeblDuepHo=; b=UStcuS0iMzOokwgaSwQDSr2SJpOYNXe5sJ/dfG71q8iaYYqnOYOy8ZRGMc+OPWzs6v 77q+q9jq3smiDiBboc1lGND08zNb2O306P78kAteHY1IPzRFhq52x4nYPgRt+H/EPLYb 63SCVsoqdUmJUbYn6ZykS4e8dZ8NzBif6mBbbUSQpt8PhwQikSi7mHqsQIOMWp6jAGAe 5RX+27tHRkysrNTJ0KfSVZkUu6ScSIy3s/4TReyjiUXiL0NnU9iLfXB2nJW/A831Nr+n wG0y3HdKm6LbZK4aIue4IHhSstiamYwjQuZtcrfp9xapX+gfCJW0HonapgCrA0EkxbgD ODVg== X-Gm-Message-State: AMke39kYqlAeSDvDuB3cd6MWHnU+XDOXKtrardWfKQpqcOnEAtSdmOpgoSeLRxbPf6uPDt8N X-Received: by 10.223.141.229 with SMTP id o92mr7135197wrb.22.1486715746534; Fri, 10 Feb 2017 00:35:46 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l67sm435884wmf.1.2017.02.10.00.35.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2017 00:35:45 -0800 (PST) From: Thomas Monjalon To: "Liu, Yong" Cc: "Tan, Jianfeng" , dev@dpdk.org Date: Fri, 10 Feb 2017 09:35:45 +0100 Message-ID: <2819058.cfIqcf5N9Z@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62D5E2F6@SHSMSX103.ccr.corp.intel.com> References: <1485156509-4919-1-git-send-email-yong.liu@intel.com> <4997476.25NJoPJnWZ@xps13> <86228AFD5BCD8E4EBFD2B90117B5E81E62D5E2F6@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 08:35:47 -0000 2017-02-10 07:53, Liu, Yong: > From: Thomas Monjalon > > 2017-02-09 22:25, Marvin Liu: > > > Add new option parse-ptype in this sample in case of pmd driver > > > not provide packet type info. If this option enabled, packet type > > > will be analyzed in Rx callback function. > > [...] > > > + if (parse_ptype) { > > > + if (add_cb_parse_ptype(portid, queueid) < 0) > > > + rte_exit(EXIT_FAILURE, > > > + "Fail to add ptype cb\n"); > > > + } else if (!check_ptype(portid)) > > > + rte_exit(EXIT_FAILURE, > > > + "PMD can not provide needed ptypes\n"); > > > > Instead of adding a new option, why not adding the callback automatically > > if the packet type is not supported by the hardware? > > Thomas, > We want to let user choice which kind of method for packet type parsing. > If start application with parse-type option, is meaning user want to use software parsing otherwise will use hardware parsing. I do not understand why this user choice matters. If it is available, hardware ptype is better, isn't it? It it is not available, we need to be aware of this specific issue, otherwise we have the error "PMD can not provide needed ptypes" (without suggesting to use the option).