From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89943432D7; Wed, 8 Nov 2023 14:40:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 785EB427E0; Wed, 8 Nov 2023 14:40:50 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 888D840A73 for ; Wed, 8 Nov 2023 14:40:49 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 118B5320092C; Wed, 8 Nov 2023 08:40:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 08 Nov 2023 08:40:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699450845; x=1699537245; bh=3+bdMKU1dGfo2RYbXwVvcV4Gt9jNLIt/2MZ 8G2zdgKQ=; b=MgSRqudRj0N7byeGrWRtRS22LSK40lLH5BOO3QQuLj8/Gx6y5Ww tzkUn1w1u/Nv0Ra3ewYNk3xsM5oHwfADJYJJcalp+x6N8Fbz9x7fT24Uld3xlL7h wnxsZWPWG7Lk99kHsuR40KCFv//GIk4I0ai+dbE1ji8s9sEu1eL70E1sJ0BVXF4C pBZO04fm8xPED2n7ubOe+opTlKdjBDbLTkLYYRoXVoe8NUfPiq2lkX1e0mvqOoUZ 6z0qi8ij4TjZF1w7sQCv0er4TiSziyBihvxVN1bqYghmElsKMJBRbzbLhzekWkur 382asSLhgPcq2P4nou2fO2zkW6rjjf8D1/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699450845; x=1699537245; bh=3+bdMKU1dGfo2RYbXwVvcV4Gt9jNLIt/2MZ 8G2zdgKQ=; b=bqGXhKT1ITexzyRvKXm+D/Owo+kdgJSDeDP4DMGhv0/8xePNua3 P5uBEIeo8F6m7RTKyrNylzFhBe7S09WcfUR/Iifp9KHqCmoXmH5phwrOS2bRldCn A/84yEjEXcFaQhHznWIn/+8XO0+SVLXZjKBFLMNBQgkfDi7pfQXS5o1RffOPLHU+ ra1OpdLsUEd74jWFhMaXMRiKUlXwN+tX4QCh+CXjp0lt0pFD8TUwxl1pnUm/S3gd PNXEvBUdsRw3ii2E7ZVlnK1VYtgu49H3yM4T3RwefeKp+0+2bbws/gFEs2NMBS2M 3X0eZEH3gYYF4F7P5VjWY5dvjadtxAPCwNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Nov 2023 08:40:44 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH] eal: fix msvc conditional compile of rte atomic thread fence Date: Wed, 08 Nov 2023 14:40:42 +0100 Message-ID: <2819904.AiC22s8V5E@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EFEF@smartserver.smartshare.dk> References: <1699387216-21396-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9EFEF@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/11/2023 09:27, Morten Br=F8rup: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Tuesday, 7 November 2023 21.00 > >=20 > > MSVC does not expose legacy atomics. When the legacy atomics were > > excluded rte_atomic_thread_fence was also unintentionally excluded > >=20 > > Adjust the conditional compilation check to expose > > rte_atomic_thread_fence. > >=20 > > Fixes: 27da6a123414 ("eal: hide legacy atomics API for MSVC") > >=20 > > Signed-off-by: Tyler Retzlaff >=20 > Acked-by: Morten Br=F8rup Applied, thanks.