From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id ECB4FCE7 for ; Tue, 7 Jul 2015 16:52:11 +0200 (CEST) Received: by wiga1 with SMTP id a1so259198530wig.0 for ; Tue, 07 Jul 2015 07:52:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=llPs048I5/AxgfxduyT5l3x8lS/uhRzUniB85ueY3rE=; b=dYX1Va8UiUoeRUAuGo0nohAbNDOCZn8lTSFQzBuZ9cZgPLmIGzSOiCSGkXj0PCWgw8 HP/ThWM/1/SqJVSUdOiriyhzwuKeIBGRykLcWgG+KYjJISbnGCQ1Jmm3ww9Wi6ES/WZh SscO0QFNqLGyiYSBmT9ZkuQ2ZyVN+fKocmk/paI/0uHw2sDSEBSjD2GfcYH0cF7Xgmzw YH2ysDBB8PoulZ+9GBVWeMBbgkCe8kumwpjfueV4AT7uFcfATA+B+eezMprvLJz3DUlT hnEXCqxQRUua2vdmTf+RHCEQcthEjZv7YaI+6kGWbiXW8I6dUiUnysbxwlGgnf73pDI7 aN2A== X-Gm-Message-State: ALoCoQkMAwn24xCPbtRmT0R9eVcxcietcW+ARE+srKdb7ggEbFhjaOCLUn9i/IS9gXN7+habrsFr X-Received: by 10.180.37.133 with SMTP id y5mr53547073wij.7.1436280731742; Tue, 07 Jul 2015 07:52:11 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id tl3sm33746170wjc.20.2015.07.07.07.52.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jul 2015 07:52:10 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" Date: Tue, 07 Jul 2015 16:51:02 +0200 Message-ID: <2821398.avzWtSOKrm@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8C59FF9@SHSMSX104.ccr.corp.intel.com> References: <1433492166-30758-1-git-send-email-jingjing.wu@intel.com> <1433917473-21508-2-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8C59FF9@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 14:52:12 -0000 2015-06-26 07:03, Wu, Jingjing: > Hi, Neil > > About this patch I have an ABI concern about it. > This patch just renamed a struct rte_eth_vmdq_mirror_conf to > rte_eth_mirror_conf, the size and its elements don't change. > As my understanding, it will not break the ABI. And I also tested it. > But when I use the script ./scripts/validate-abi.sh to check. > A low severity problem is reported in symbol "rte_eth_mirror_rule_set" > - Change: "Base type of 2nd parameter mirror_conf has been changed > from struct rte_eth_vmdq_mirror_conf to struct rte_eth_mirror_conf." > - Effect: "Replacement of parameter base type may indicate a change > in its semantic meaning." > > So, I'm not sure whether this patch meet the ABI policy? I think it's OK. > Additional, about the validate-abi.sh, does it mean we need to fix > all the problems it reports? Or we can decide case by case. > Can a Low Severity problem be acceptable? We have to decide case by case. It makes ABI checking impossible to automate. That's why any help is welcome to check the git HEAD for ABI violation.