From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: stable@dpdk.org, Wei Zhao <wei.zhao1@intel.com>,
bernard.iremonger@intel.com, ferruh.yigit@intel.com,
arybchenko@solarflare.com, jerinj@marvell.com,
konstantin.ananyev@intel.com, olivier.matz@6wind.com,
david.marchand@redhat.com, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix to add offloads confguration for queue
Date: Sat, 06 Jul 2019 18:25:45 +0200 [thread overview]
Message-ID: <2821745.aYemArvfLF@xps> (raw)
In-Reply-To: <4930276.8mQHqxAZBW@xps>
06/07/2019 18:24, Thomas Monjalon:
> 04/07/2019 07:35, Wei Zhao:
> > When adding offloads from commandline, not only port
> > related configuration bits should be set, but also queue
> > related offloads configuration bits, or it will cause error.
> > For example, test in this process for ixgbe:
> > (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4
> > -- -i --portmask=0x1 --port-topology=loop --disable-crc-strip
> > (2)port stop all
> > (3)port config all crc-strip on
> > (4)port start all
> > we will see "Fail to configure port 0 rx queues" of warning info.
>
> I'm really surprised it was so much broken.
> I did not check the code. Someone else did?
Adding more Cc for double check.
next prev parent reply other threads:[~2019-07-06 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 5:24 [dpdk-dev] [PATCH] " Wei Zhao
2019-07-03 11:46 ` Iremonger, Bernard
2019-07-04 5:35 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-07-04 8:53 ` Iremonger, Bernard
2019-07-04 23:54 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-07-06 16:24 ` Thomas Monjalon
2019-07-06 16:25 ` Thomas Monjalon [this message]
2019-07-08 9:09 ` David Marchand
2019-07-08 9:16 ` Zhao1, Wei
2019-07-08 9:22 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2821745.aYemArvfLF@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).