From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1398A0487 for ; Sat, 6 Jul 2019 18:36:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6ED294C8F; Sat, 6 Jul 2019 18:36:08 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 2042A374C; Sat, 6 Jul 2019 18:36:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 7DFF81772; Sat, 6 Jul 2019 12:25:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 06 Jul 2019 12:25:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZUt1OJipI5hpx+ecHWBNmE+qjktWfvVSiZUZeBlW+mo=; b=BziWhvDfKqe/ kYoDl/pjNZ7NfUFKDWcXZGkYp0cqHXH3COndXv+D6BfZODM4rpXEiJkuHIEgS7Rd mrmDqrJIxF9m+pVyCx4jBqjspHsvZ32xeLcY4Eiw5QtxdmGSUMg0nZGfc3kGkUR9 QkOtdhQHResPKZH4v01fT5jfqeANrKM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZUt1OJipI5hpx+ecHWBNmE+qjktWfvVSiZUZeBlW+ mo=; b=FePgkcX0raj+mKTRvwgiNLsvRJlh3hNP3XQtugkactL+fpOetYQk/VLpn iL8ncmNP9me1o3gQbx2lLpnYikeqwofr4LyvkMW87O3Ed23iJa1hAYiv6y8fUmVu Zx6L2sgwXpJ8scLY9sEerVYV+aAtA5sfyhLve362Uf1wDsCNT/UsIMVCi+1jO8xg lbcdVaGJvmNTlj7YWe8TicbMNK3a3/H34BMZiIr57v3WcsHTTdT3RWTM86tF27y/ ExAETDXAiJFOqsuIKuwq194pLRAfI3h9y57jqQRhJSILUQ4xV/gGJWqPJJ7nWXBN AqX45LyyJ1NnyHmDgUsA5zFlAgdug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfeeigddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E86A80061; Sat, 6 Jul 2019 12:25:47 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, Wei Zhao , bernard.iremonger@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, jerinj@marvell.com, konstantin.ananyev@intel.com, olivier.matz@6wind.com, david.marchand@redhat.com, adrien.mazarguil@6wind.com Date: Sat, 06 Jul 2019 18:25:45 +0200 Message-ID: <2821745.aYemArvfLF@xps> In-Reply-To: <4930276.8mQHqxAZBW@xps> References: <1562131464-58732-1-git-send-email-wei.zhao1@intel.com> <1562218537-33583-1-git-send-email-wei.zhao1@intel.com> <4930276.8mQHqxAZBW@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix to add offloads confguration for queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/07/2019 18:24, Thomas Monjalon: > 04/07/2019 07:35, Wei Zhao: > > When adding offloads from commandline, not only port > > related configuration bits should be set, but also queue > > related offloads configuration bits, or it will cause error. > > For example, test in this process for ixgbe: > > (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 > > -- -i --portmask=0x1 --port-topology=loop --disable-crc-strip > > (2)port stop all > > (3)port config all crc-strip on > > (4)port start all > > we will see "Fail to configure port 0 rx queues" of warning info. > > I'm really surprised it was so much broken. > I did not check the code. Someone else did? Adding more Cc for double check.