From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 4509B568F for ; Thu, 30 Jun 2016 18:10:54 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id v199so227860711wmv.0 for ; Thu, 30 Jun 2016 09:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=NXToocLqaebpP9o5eaG2cQ0eRtUJM2aO66PtRyv+UvU=; b=PwzzH+GWDAlpFON2ySk6rQHEYEcvzY/G4Ii/LYfZkT2u0NxFng3d+nxBmkeu9Qzp2N G+XyEFMnJAUmcpkskJXeapcS0Ie8TvC7AodkRjVmWWTcZtQVDWT/gpFOX2ykgfOvnYow lGlLr+1Qnz/+Pf81HDZZ28UHMpq6aQf4JSRLuhygindeYN40XpzHRzxGPhWv9V8pV2SI b2RKpaF2Rr1NyzNOvNmGbKkwXykJVUIgrXosEFksXQmGalFoEgtFGjQNxDLJI2+k9aY3 fFNcEQ50kTRcC/YOAUz1qw9/Yp9R/L2Ap8AhmfCeL+ia/cBrpXnS5IvDwOHFpf0PQMmL kIPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=NXToocLqaebpP9o5eaG2cQ0eRtUJM2aO66PtRyv+UvU=; b=QJCAiusOExqb4JJ3rJ831kfJxmMh7Ai9jodIlKyNKx1zDHj7Wl47ZaNF+HTmC/cIwS 7o8BoiM7dETFpU/2X+XRrFk3eDme6a9QRqfBEfVWFQeLK5wEfgwkkQf7hNKYb57B7iyq 56C5YLwJ2bgp28NkKjtFK4OWtNX/j2CTwKZKmzf6lXWkx/MJEJv+DB4w8v0uP2MRR8CE 9UaHW4/lwslZaP6yw5NZao3XCba2yaXjYMy08Ru3KbosmNUcL4sJHBiiXmTJoy8vO6MS SpSOj6jwYGE526Pekx4QKmnfywmyxwL0lUbK/Fa2bWzUGP24GDhWL7NVpymuRMCpw60d Aofg== X-Gm-Message-State: ALyK8tJTACAaCodSkCFjJl97AnldKVhPK35oMT/SyIeYxVV+Xj8ic+aEwHeWoxccygnZX3qE X-Received: by 10.28.199.205 with SMTP id x196mr14787339wmf.96.1467303054017; Thu, 30 Jun 2016 09:10:54 -0700 (PDT) Received: from xps13.localnet (188.16.90.92.rev.sfr.net. [92.90.16.188]) by smtp.gmail.com with ESMTPSA id ze10sm3365395wjb.2.2016.06.30.09.10.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 09:10:52 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Thu, 30 Jun 2016 18:10:20 +0200 Message-ID: <2826363.SrA66T9uvx@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1467302516-106285-1-git-send-email-sergio.gonzalez.monroy@intel.com> References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1467302516-106285-1-git-send-email-sergio.gonzalez.monroy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 16:10:54 -0000 2016-06-30 17:01, Sergio Gonzalez Monroy: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag > _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter > _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched > _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM) += -lrte_lpm > -_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += -lrte_jobstats > _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) += -lrte_power > > _LDLIBS-y += --whole-archive > > +# librte_acl needs --whole-archive because of weak functions > +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH) += -lrte_hash > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lrte_vhost I was suggesting to keep -lrte_acl at the same place in the group of algorithms libraries, in order to keep an order satisfying this comment: # Order is important: from higher level to lower level But I have not tested if --whole-archive -lrte_acl --no-whole-archive works.