From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id C4AFF2EDA for ; Tue, 2 Jun 2015 14:38:54 +0200 (CEST) Received: by wibut5 with SMTP id ut5so67868946wib.1 for ; Tue, 02 Jun 2015 05:38:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=I1SSnL0Fco2lfdSdludFproyMojBqhblWTykkKbdbVQ=; b=NqrH1NaqCUDTrir8Q9Q6vQrruOl8rhGmrx5P4y2Eth6alydVPv34nPbKThNdVjslcS MB+/rvqCOFGhs5cNjX9BSJc2R72D4uOhoD20aBA+r6bCV1SnQkVEY87qxB293NW97QW5 0VK94QCkxCPrG1WZezN82qshWB8eThuORDUF8arLdKSneGkK9Gbn3UXFXM+7FKz4vatX 2wlpUHBSgO0v1xzVquBE+tlh9F+66Bsyl/LetFcHYBzeXSSey4E3NmOJn1HFv0Hy3i+i wB/Kwc13T8+mrrPAnHcUD91SQF4VVIy4M85Ll34ns//kR2vdLbgHcNd7+m78mF4cGZGT XWqg== X-Gm-Message-State: ALoCoQk9OZN7cpnCTx5T2wl6blJ7wmtThg7+WeNg/mRXDXiT4reXAI7hlAH+xFUsNcm7kJ19s4Zt X-Received: by 10.180.198.166 with SMTP id jd6mr29921695wic.48.1433248734608; Tue, 02 Jun 2015 05:38:54 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id hn7sm21413347wib.5.2015.06.02.05.38.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jun 2015 05:38:53 -0700 (PDT) From: Thomas Monjalon To: Liang-Min Larry Wang Date: Tue, 02 Jun 2015 14:38:06 +0200 Message-ID: <2827467.MLJnnY93Dx@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1432927612-12244-3-git-send-email-liang-min.wang@intel.com> References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <1432927612-12244-3-git-send-email-liang-min.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 12:38:54 -0000 2015-05-29 15:26, Liang-Min Larry Wang: > adding a new library based upon ethdev APIs to provide API's that bear > the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops > (linux/netdevice.h). > > Signed-off-by: Liang-Min Larry Wang > --- > MAINTAINERS | 4 + > config/common_linuxapp | 5 + > lib/Makefile | 1 + > lib/librte_ethtool/Makefile | 56 +++++++ > lib/librte_ethtool/rte_ethtool.c | 155 +++++++++++++++++ > lib/librte_ethtool/rte_ethtool.h | 257 +++++++++++++++++++++++++++++ > lib/librte_ethtool/rte_ethtool_version.map | 18 ++ > mk/rte.app.mk | 1 + NACK for several reasons: - It's unclear what benefits this ethdev wrapper is bringing - There is no obvious interest (how is it supposed to be used?) - There is no update in the doc/ directory Other comments: - the patches are not versionned - the copyright starts in 2010 I'm curious to understand how renaming rte_eth_dev_set_mtu() to rte_ethtool_net_change_mtu() will help anyone.