From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 268EFA0542; Mon, 29 Aug 2022 10:04:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 097734069D; Mon, 29 Aug 2022 10:04:58 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id E182040694 for ; Mon, 29 Aug 2022 10:04:55 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9814F5C00AD; Mon, 29 Aug 2022 04:04:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 29 Aug 2022 04:04:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1661760295; x= 1661846695; bh=74Bi+Ctfkuu1Fq9Kw5irah0hMoejMoi9W/F4kiTXn9I=; b=P SU1b7Pjr608M659oPrJnaEno1tnD4LhyswdId9HPdxO4BKNEvqbqzRPzA5xsOrZc 71Id7a6xCR3Kb9LeMJe0VbVl7CdH3kIFaVFBnCn/w9NiYopLs5pK1cZZUkQ9LtKC yqvx1oI9W8jqb8URh3dJcikwZTjnJqxGFsIwbNWCBzuu13ji72VajkNaXKBds6vc ZEX9TubFOdDmVlwWAboReNhVkeUk2csC2n7GK2PUkfQ50NWMXbUqc2L+tQiNKUYJ QxOb3mZbpwKWY623jAHaV5az5d8NcyET5EDXAi+bYGgm0PHk03Up1Bx2XhlWW1/A oyJHc1euGjVlU/kLSmjWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661760295; x= 1661846695; bh=74Bi+Ctfkuu1Fq9Kw5irah0hMoejMoi9W/F4kiTXn9I=; b=F a/Qv0N1d6yIz/ak6sEkmbCrk10pC9LJUExqpkrgB/3tulzPmlVa9FbQ9EwRIdImp 5lfpztVCh8bUG+vMyXDHDyHtLtgVakZ/U8Qohd5R483Chy73Sai7MyKidqD+QZl2 p5FLbi75vUry3hyob5z4lMPbrTW2K9qKGnSyPDHifXTVHg7azryAzp+Ux06GkokS x6o0yFfw0N8vIWm3ym/JY7uY+7fjNDp3YHMRciIXUlNr9bW9H7RtUMrh2kfdiBdE y8yzWw4jNdi5SGWddrvz1j6I6FaIvVykXakcv9sFH+F6mkwGYzjSlYkPZdf0u8U3 jsbPkDjFoLjarrEyHha8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekudcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieekgfek udehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 04:04:54 -0400 (EDT) From: Thomas Monjalon To: Pallavi Kadam , dmitry.kozliuk@gmail.com Cc: dev@dpdk.org, Narcisa.Vasile@microsoft.com, roretzla@linux.microsoft.com, qiao.liu@intel.com, "Menon, Ranjit" Subject: Re: [dpdk-kmods v2] windows/netuio: fix BAR parsing Date: Mon, 29 Aug 2022 10:04:53 +0200 Message-ID: <2833470.SvYEEZNnvj@thomas> In-Reply-To: References: <20220802191058.1779-1-pallavi.kadam@intel.com> <20220811221723.2124-1-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/08/2022 20:13, Menon, Ranjit: > On 8/11/2022 3:17 PM, Pallavi Kadam wrote: > > Current code was always checking the 'prev_bar & PCI_TYPE_64BIT' > > though only the first BAR slot of a 64-bit BAR contains flags. > > Also for certain PCIe devices, BAR values were not continuous. > > This patch fixes this incorrectness and maps the BAR addresses > > correctly. > > > > Reported-by: Qiao Liu > > Suggested-by: Dmitry Kozlyuk > > Signed-off-by: Dmitry Kozlyuk > > Tested-by: Pallavi Kadam > > --- > > windows/netuio/netuio_dev.c | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > Acked-by: Ranjit Menon Applied, thanks.