From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 010E24C74 for ; Sat, 31 Mar 2018 15:16:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6C0BF210A4; Sat, 31 Mar 2018 09:16:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 31 Mar 2018 09:16:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=iXIEAfcy3IaT8Bs/SLAnqr6d9A VLNV6NTz01+A16QfU=; b=bAvq0FC2hD/pmOY0X+p41wCSkSgXvcY/XASkrrVRdU n723m0dmfCqzk+7dPNaXcb3QSU0gN8EK+sEXSb+Ti0Oix03MBED9faD+cwm4dpwv QIHEU+RE/zT7+pvjZ6uMi6M/GdNjEtj7WztAasSuT8Q4Y1ljvtYK0aynJkwGq0+s Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=iXIEAf cy3IaT8Bs/SLAnqr6d9AVLNV6NTz01+A16QfU=; b=MrlToGvKoRDRXQvIO+0xR1 5QQxQDrqyx6pmXB/DEsItx6YUPBPBSBX0MHvvmc61TvYIUex3qTWNslybJcYLwG2 eeOCmpyRuDPb3wtowh+r2ZiCpJYPDCjTIWEK8m4P0gSHK/CLqPoh2/Sk807RjLiX aW05ogZWnAwD+fMAU5gJ8NLoQwyx6Id8gMzLhDecLRc2KNWwZvPFX1tdgJLAMFM/ /ZkXIrmfsa9xZGk341zLnT4Chb3AgNDLI9kJ4GafDF+v9VDxmH9l12SXLAFJ9iQ/ 2Sn8CAvuc+q5QBIBceLu6w/5CKOulxk2FaUTp4eiFZRF6LCoimarxn0jrH9YzU2g == X-ME-Sender: Received: from xps.localnet (230.202.154.77.rev.sfr.net [77.154.202.230]) by mail.messagingengine.com (Postfix) with ESMTPA id BE8E210255; Sat, 31 Mar 2018 09:16:37 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin Cc: Xiao Wang , ferruh.yigit@intel.com, dev@dpdk.org, zhihong.wang@intel.com, yliu@fridaylinux.org, jianfeng.tan@intel.com, tiwei.bie@intel.com, cunming.liang@intel.com, dan.daly@intel.com, gaetan.rivet@6wind.com, anatoly.burakov@intel.com Date: Sat, 31 Mar 2018 15:16:20 +0200 Message-ID: <2836028.8kLeaZ6SVA@xps> In-Reply-To: <1496487c-f3ea-dc34-dee7-dbaf40d54a97@redhat.com> References: <20180321132108.52464-4-xiao.w.wang@intel.com> <20180331022929.42172-3-xiao.w.wang@intel.com> <1496487c-f3ea-dc34-dee7-dbaf40d54a97@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/virtio: skip device probe in vdpa mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 13:16:43 -0000 Hi, 31/03/2018 13:13, Maxime Coquelin: > On 03/31/2018 04:29 AM, Xiao Wang wrote: > > If we want a virtio device to work in vDPA (vhost data path acceleration) > > mode, we could add a "vdpa=1" devarg for this device to specify the mode. > > > > This patch let virtio pmd skip device probe when detecting this parameter. > > As we discussed, I would prefer a generic solution at EAL level. Please could you explain the requirement and the context? Can we use RTE_ETH_DEV_DEFERRED state and device ownership? Without knowing what's behind, I would say that a PMD should never skip a device by itself, but let other entities decide what to do with the probed device (thanks to probe notifications).