From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 4480E2B9E; Thu, 17 Jan 2019 17:42:01 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1756E148B; Thu, 17 Jan 2019 11:42:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 11:42:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FFYkYMNkYguql3tgnLzPLXI4Q3WTykEbKJMTNUp80dI=; b=J2qeiyT8woni vm5l63X6X5FmVfetbq60WdHywYlAEqPCbVl62p2JapfATIY5jdHsanYyEYU0br4J TSPMcLjxEw8Cx9GT20s6rcU/jRZmo9x3RLSZxvTV+jULoWyv33m5iui9wyRz6OgO UA6/+aW7876qLlzg9kUxmJ98AR50m88= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FFYkYMNkYguql3tgnLzPLXI4Q3WTykEbKJMTNUp80 dI=; b=E4Ww4AoxMGwbFVdw/CT46XsZCrQSYgz+uQyK5qJMGgZ0kr4yI8V7/RHt7 bb3u/AFk4YvQCbVYwITlEgRbpsq7yB7DmdKS11uY8ZWGCmbHbC+nwuNMg3ZAWNzv pFwFoMJOEN1d2oRLlKQw8KnQgzbr162Ev3ZUiwMcfVUSHEWcoJNgd4Vozdlsx0ne J8jpnXrEsJ/pu/qw8J0GkrN3606NqlUd545ZsX3SOakue6+SYkIVrrDtIdt6n5lp 9F7hL6BaXQl45ZiCYRUdU0Gr+rUoLppUpEy020tUUGsl3joTUeD6ShQsPu9hEFSV N1U+f/O4B02uzu3PIW223bWZqEfkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 659A410085; Thu, 17 Jan 2019 11:41:58 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, yuwei1.zhang@intel.com, bruce.richardson@intel.com, stable@dpdk.org Date: Thu, 17 Jan 2019 17:41:57 +0100 Message-ID: <2838296.dFoSHF3S7s@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: check string parameter lengths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 16:42:01 -0000 16/01/2019 13:12, Anatoly Burakov: > When specifying parameters such as hugefile prefix from the > command-line, it is possibly to supply an empty string. This may > lead to various problems: for example, if hugefile prefix is > empty, the runtime config path construction may end up > looking like "/var/run/dpdk//_config", which will technically > work, but is wrong and places files in the wrong place. > > To fix it, check lengths of such user-specified parameters for > hugefile prefix, as well as hugepage dir and user-specified > mbuf pool ops string. > > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks