From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2E23A053A; Wed, 5 Aug 2020 10:28:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3AA21C030; Wed, 5 Aug 2020 10:28:38 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 3F9001BFF5 for ; Wed, 5 Aug 2020 10:28:37 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id C0F485804DD; Wed, 5 Aug 2020 04:28:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 04:28:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= XDCuXMBsKvUwHZ7NPHg4ERFz3lbtvsUbux9mXpgPqqI=; b=vEmTzbWLfscu+0jb 501ok/Db1pNpDhk5LAj7zHH7CxCIiq37EmHm9M1WMxPN7nILGMgGRvk2rKF1X23c 5oDNq+UWtdCyEvNa6gxl421NQOvyI5PZ/wKej/NuTGuRvfGJNSDswouR5em1Pslg AVXFDhNDjPboxJLreSpoHKiMZijREmfvTYdEdOO7dLYy4Wv8d5KixbGrNmasRH9w W9z3U9gvK/R64BhMAaB1yCj8kBvveIjLBv43DxVMzfx2BikyRKO4NjuhdDIAWlhb AXsa16LTeWzernrYX/M4Uh1lV9vMlaDQP4pOfBpK6WUtXPG9XVir8COMrmzcanPs HcvOIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=XDCuXMBsKvUwHZ7NPHg4ERFz3lbtvsUbux9mXpgPq qI=; b=D90UGNpu6wdqvMoPs4vCrC2YaTQ0gxd0TSPKps7BXbpRGc9aRttU0kD8G 4BY70JLYOBuGZkkEpKPsPGkZrwM0pyQXGnjZJYU3XhrgaRi9/5Hm2o8fKD/xJrAz 0DpkKANLf7cH16zYOKGC/yKRtPOwqT7jyayYJMtYa5n0xkvhSepm4rWwq1LE0cYV IWFGyHcoWvcADZEu3FbZyLIco90lCRgsfRoRokzhknRk3pESv2giz288H+7dU3QL 9Tae1frJXEc5O4jb5CZSxIeuNTlL/mUWYzeOQ09C82pEgOBElJmUw0f9PZjUXUOr 2qY+ipAZ/0JBh7htAsrykvrdCW3fA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2096B3280064; Wed, 5 Aug 2020 04:28:35 -0400 (EDT) From: Thomas Monjalon To: Fady Bader Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ciara.power@intel.com, navasile@linux.microsoft.com Date: Wed, 05 Aug 2020 10:28:34 +0200 Message-ID: <2844446.FSDoYEOMMg@thomas> In-Reply-To: <20200804062947.6176-5-fady@mellanox.com> References: <20200625133038.25180-1-fady@mellanox.com> <20200804062947.6176-1-fady@mellanox.com> <20200804062947.6176-5-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/08/2020 08:29, Fady Bader: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_telemetry/rte_telemetry.h | 4 +++ > lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++- > lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- > 3 files changed, 79 insertions(+), 2 deletions(-) The removed lines are blank lines which should remain.