From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 777555583 for ; Wed, 21 Jun 2017 11:58:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D089120C79; Wed, 21 Jun 2017 05:58:13 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 21 Jun 2017 05:58:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=VytuEuppHFqM01f 9Ieu+n/fh8WCs0wokrWVkGr/3WNg=; b=IQm1lwgsd9x+9qslmvGjwB67+YID3AZ V3yUj33ly7kA8Z3/y/GUoMH6F5mxguwLHPMuwLxO06ThzdPhBTchaLvqO5kqCtgS GSAzq2FGR+1raTttYiFGWZlN+/TcwowtR+sg7PE4/eA35zwROfkGN57e1g+XIe2r s5jPKpBUduTI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=VytuEuppHFqM01f9Ieu+n/fh8WCs0wokrWVkGr/3WNg=; b=kOamuGOq A/O0x7ivycQJlqwPImZETw3ihpmejiwj3eDY8aVVzamelWPgOxsWWWzAwVY2qlQq XoUqAn/4sM8+iwZtB1HgZYeG7B24RSbwbOdD4zej7WqgZnpB/IAWPi18hqhoGKQ+ 7HvJpiqZxHiPwaz9oDYy8Zkmm2dD23pm6FPd8Iqq81ptao9uMXPYje5W4uKuxLRN D1Ao8n0yL89fBpbvi3HEL7be9h1Nww0/xrtMsDoL6SlXugL8mw8QhgQpFYK48Fq3 AdbUwrlLS5nICNT/2vnJJIjaon3MbvwBlCQ3OhB0qXEaEYhaCUid+GGmOMHcdouh w3VYnyKG56SoRQ== X-ME-Sender: X-Sasl-enc: J64UAezQYVmoHtLyIeH6DcJLwdeMCcPRbDn12xWEzfVP 1498039093 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 850647E760; Wed, 21 Jun 2017 05:58:13 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Sergio Gonzalez Monroy , Hemant Agrawal , Ilya Maximets , dev@dpdk.org, Bruce Richardson , David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei Date: Wed, 21 Jun 2017 11:58:12 +0200 Message-ID: <2845661.r9ChRO7rgB@xps> In-Reply-To: <20170621092744.GA26030@jerin> References: <1496736832-835-1-git-send-email-i.maximets@samsung.com> <3795576.X6Zydzo19D@xps> <20170621092744.GA26030@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 09:58:14 -0000 21/06/2017 11:27, Jerin Jacob: > -----Original Message----- > > Date: Wed, 21 Jun 2017 10:49:14 +0200 > > From: Thomas Monjalon > > To: Jerin Jacob > > Cc: Sergio Gonzalez Monroy , Hemant > > Agrawal , Ilya Maximets , > > dev@dpdk.org, Bruce Richardson , David > > Marchand , Heetae Ahn > > , Yuanhan Liu , Jianfeng > > Tan , Neil Horman , Yulong > > Pei > > Subject: Re: [PATCH v5 0/2] Balanced allocation of hugepages > > > > 21/06/2017 10:41, Jerin Jacob: > > > > > 1. There are many machines (arm/ppc), which do not support NUMA. > > > > > > > > > > https://wiki.linaro.org/LEG/Engineering/Kernel/NUMA > > > > > > > > > > > > > I did find that link too, last modified 4 years ago. > > > > Despite that, I could not find any ARM references in libnuma sources, but > > > > Jerin proved that there is support for it. > > > > > > > > http://oss.sgi.com/projects/libnuma/ > > > > https://github.com/numactl/numactl > > > > > > Those Linaro links are very old. ARM64 NUMA supported has been added in 4.7 kernel. > > > I guess we are talking about build time time dependency with libnuma here. > > > Correct? I think, Even with old arm64 kernel(< 4.6), You can build against > > > libnuma if it is present in rootfs. Just that at runtime, it will return > > > NUMA support not available. Correct? > > > > > > How hard is detect the presence of "numaif.h" if existing build system does not > > > support it? If it trivial, we can enable RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES > > > if build environment has "numaif.h". > > > > > > Some example in linux kernel build system: > > > http://lxr.linux.no/linux+v4.10.1/scripts/gcc-goto.sh > > > > I think we should not try to detect numaif.h, because it should be > > an error on platform supporting NUMA. > > I have installed libnuma on a NUMA and non NUMA machine. > Compiled and ran following code on those machine and it could detect > the numa availability. Could you add more details on the "error on > platform supporting NUMA". I was saying that we do not need to detect NUMA. If we are building DPDK for a NUMA architecture and libnuma is not available, then it will be a problem that the user must catch. The easiest way to catch it, is to fail on the include of numaif.h.