DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: select patches to check with git range
Date: Fri, 10 May 2019 00:05:25 +0200	[thread overview]
Message-ID: <2845816.AoUcc6ncKd@xps> (raw)
In-Reply-To: <2117699.YQSt9e6Vg7@xps>

09/05/2019 23:54, Thomas Monjalon:
> 22/03/2019 14:16, David Marchand:
> > --- a/devtools/checkpatches.sh
> > +++ b/devtools/checkpatches.sh
> > -	usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]]
> > +	usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]] [-r range]
> 
> The option -r should be before the filename arguments,
> and inside the same brackets as -n as they are exclusive.
> (je clair ne pas ;)
> 
> >  	The patches to check can be from stdin, files specified on the command line,
> > -	or latest git commits limited with -n option (default limit: origin/master).
> > +	or latest git commits limited with -n option or commits in the range
> > +	specified with -r option (default: origin/master..).
> 
> I suggest this reword:
> 
>   	The patches to check can be from stdin, files specified on the command line,
> 	latest git commits limited with -n option, or commits in the git range
> 	specified with -r option (default: "origin/master..").
> 
> [...]
> >  	if [ $number -eq 0 ] ; then
> > -		commits=$(git rev-list --reverse origin/master..)
> > +		commits=$(git rev-list --reverse $range)
> >  	else
> >  		commits=$(git rev-list --reverse --max-count=$number HEAD)
> >  	fi
> 
> Looks good and very useful, thanks :)

I'm sure I'll find this new option quite useful,
so please add my agreement:
Acked-by: Thomas Monjalon <thomas@monjalon.net>

  parent reply	other threads:[~2019-05-09 22:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 13:16 David Marchand
2019-03-22 13:16 ` David Marchand
2019-05-09 21:54 ` Thomas Monjalon
2019-05-09 21:54   ` Thomas Monjalon
2019-05-09 22:05   ` Thomas Monjalon [this message]
2019-05-09 22:05     ` Thomas Monjalon
2019-05-10  7:49 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-05-10  7:49   ` David Marchand
2019-05-10 13:44   ` Thomas Monjalon
2019-05-10 13:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2845816.AoUcc6ncKd@xps \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).