From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97437A00C2; Thu, 10 Feb 2022 10:32:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 397754013F; Thu, 10 Feb 2022 10:32:22 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id EBB9940041 for ; Thu, 10 Feb 2022 10:32:20 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 30F36580151; Thu, 10 Feb 2022 04:32:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 10 Feb 2022 04:32:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=11tQX42eL+Box8 UPCiXdJef396+AV18cN+DPWZ3h8Os=; b=iasP6cBRKsJ7OD+TeL4HgI5t5jVa8C 4pzQd3ctkFVSjayN05mGMNZkqIJSUjGRcEdDvBpid5H4HYK+UVz/rnMJMFfoBmez tFHCTXhBnlo3I8XGzuHlivngv9SGDMQuTXvfkC+FcCYZ9h5EOdUHuhi+rO9cVoZQ luiLwlZm6hbUfLZE7ivxiZsiu90WPCGCEXTDdZ/JdAv9MupzlekHjEpMdyjWn8ge d/J95uV06MilULjrwzCDalJJc08fUZSBPLb5sOa+az9bdgPQ4fuZZwXzh2jIIBHq 1diB4GOoiOZGm4bRn8AIJCmil3AmQ8xF9eBlvqC4j0mUdG64yHsefLTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=11tQX42eL+Box8UPCiXdJef396+AV18cN+DPWZ3h8 Os=; b=YGD7wzk6ZheacCtkYCkXmu8u9xuu1bQUgQxo0jddMIF2kMSNIlvMlbmhY TDmrFhRduU5s5Jm4VNsYkGpI8Je/5EZu6/1LIjtfj2utqg6/9Nl2a/a5Ja6P4tEr HZG9uMKMJ1GewQcWqSQm/4Yoj9a4+OkK1kUShYr1vUdkCvVifhNqN8x+LmHOcySm /64VXqvTM1hP95AxRz6nnAWFQPS8GnCVR1BzQLlt3bZ8WRaUYYoX5cy4tuf7bal+ aKrbK1TuC1lJ+nSinq/eSC6Qoo5qSgXtszP9dsuzO5Ki7lakp6gzfN+KzthZ8h2F QAQHPJSh0RtTbvcmFnVp0EAc/MG+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddriedugddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Feb 2022 04:32:17 -0500 (EST) From: Thomas Monjalon To: Alexander Kozyrev Cc: dev@dpdk.org, orika@nvidia.com, ivan.malov@oktetlabs.ru, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com, mohammad.abdul.awal@intel.com, qi.z.zhang@intel.com, jerinj@marvell.com, ajit.khaparde@broadcom.com, bruce.richardson@intel.com Subject: Re: [PATCH v4 04/10] app/testpmd: implement rte flow configuration Date: Thu, 10 Feb 2022 10:32:15 +0100 Message-ID: <2847182.VdNmn5OnKV@thomas> In-Reply-To: <20220209213809.1208269-5-akozyrev@nvidia.com> References: <20220206032526.816079-1-akozyrev@nvidia.com> <20220209213809.1208269-1-akozyrev@nvidia.com> <20220209213809.1208269-5-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/02/2022 22:38, Alexander Kozyrev: > Add testpmd support for the rte_flow_configure API. A note about the titles for testpmd patches in this series: You don't "implement" because it was implemented in rte_flow.c. Instead, better to say "add" in the testpmd app context. Also you should not mention "rte flow" with a space. It's better to keep rte_flow with underscore (even if discouraged), or in a more verbal English manner, just "flow" if it is enough to understand. Here I think it could be: app/testpmd: add flow engine configuration