From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51D26A04A4; Sun, 24 May 2020 22:58:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 781DB1D51D; Sun, 24 May 2020 22:58:00 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 3C3161D452 for ; Sun, 24 May 2020 22:57:59 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3B9CD974; Sun, 24 May 2020 16:57:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 24 May 2020 16:57:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= g/rrFBE6fyWfz/F5pU2tOTu/4MgHXNOs1OT9HPJJ+q0=; b=VF2nuCsYO1WLEBCG 2MCYFtriO5PDAmK/KOehkR5Rst0hP8KYmw/VXY56uPqTLnv+qfvKkzd8q+7I88m/ 32TvbT33FdNQb8cA/ztQ6qA1pcFY5NYUmxq5XyJ4qkd5aLkeYNEwcG7qqxWZUtYF 65D2zVimfbSSPEr4NRme/ygWzV2TN4DIs6StITqmAMN/3aV1gi2cOpMaqtn7+8U6 IV8CG3aru9UXeJ4ZhtwiVPmnU2zskPspLPmce3QrcwYMl5ucziUC63+Gxyz487Rq Bk4i98D5ui3aRKMUPmVD5FJgHdEunc/BNbt6QWTKtZc7W7sk1puKP6if6+07kEMh uBf9Zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=g/rrFBE6fyWfz/F5pU2tOTu/4MgHXNOs1OT9HPJJ+ q0=; b=NoWexsFKjriHftGNYpXzHHCQBuDbWxgKAF/aAi0Z3fFrb5uXzYB+17nCG M1O8jgw2JMcFPXPHR/dRr+WkHd3u20dPiKV5e1a2kn2eb6JZCfK515ju2WIy2LSH ePvWeNgmnS6I1t2iGGaX+tS6mam6WeRvijf0pIEgBxlrIKGA2FmMInk+1Q6PcRjI GUX52Gkx6+iaTTQF2o1YUbVwzoFNqOHOn/TRkG6xHsdV9A02el5fJc5BU6nHFnZ/ WM4nDmbXyRMBFHJm9CKdne3zCahwgLOKu+AuM54RkCQv7+sd4g8T/XX2NH7d+z+h w7X800ft6fegBklyLLlwXFzzXFnMw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 300AD306653B; Sun, 24 May 2020 16:57:56 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org Date: Sun, 24 May 2020 22:57:55 +0200 Message-ID: <2851297.CiCCzYk1py@thomas> In-Reply-To: <20200506095526.27664-2-ciara.power@intel.com> References: <20200128150256.14339-1-ciara.power@intel.com> <20200506095526.27664-1-ciara.power@intel.com> <20200506095526.27664-2-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: standardize script arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/05/2020 11:55, Ciara Power: > This patch modifies the arguments expected by the check-git-log script, > to match the format of arguments for the checkpatches script. Both > scripts now take certain argument options in the same format, making > them easier to use. > e.g. Both now take a commit ID range by "-r " [...] > - usage: $(basename $0) [-h] [range] > + usage: $(basename $0) [-h] [-nX|-r range] Why not specifying that range can be also the first argument? It is a discrepancy with what is documented in doc/guides/contributing/patches.rst > Check commit log formatting. > - The git range can be specified as a "git log" option, > - e.g. -1 to check only the latest commit. > - The default range starts from origin/master to HEAD. > + The git commits to be checked can be specified as a "git log" option, > + by latest git commits limited with -n option, or commits in the git > + range specified with -r option. > + e.g. -n1 to check only the latest commit. This line "e.g. -n1" looks disconnected from the above lines. > + The default starts from origin/master to HEAD. The rest looks OK.