* [dpdk-dev] [PATCH] eal: fix leak in hotplug add on parse error
@ 2017-08-03 12:34 Gaetan Rivet
2017-08-03 20:06 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Gaetan Rivet @ 2017-08-03 12:34 UTC (permalink / raw)
To: dev; +Cc: Gaetan Rivet
If rte_eal_devargs_parse fails, the rte_devargs has not yet been inserted
in the global list. When jumping to err_devarg, the removal fails and it
is not properly freed.
Free the allocated rte_devargs if its removal failed.
Coverity issue: 158658
Fixes: 7e8b26650146 ("eal: fix hotplug add / remove")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
lib/librte_eal/common/eal_common_dev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index d19232d..fc8a4d2 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -204,7 +204,10 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,
return 0;
err_devarg:
- rte_eal_devargs_remove(busname, devname);
+ if (rte_eal_devargs_remove(busname, devname)) {
+ free(da->args);
+ free(da);
+ }
err_name:
free(name);
return ret;
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix leak in hotplug add on parse error
2017-08-03 12:34 [dpdk-dev] [PATCH] eal: fix leak in hotplug add on parse error Gaetan Rivet
@ 2017-08-03 20:06 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-08-03 20:06 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev
03/08/2017 14:34, Gaetan Rivet:
> If rte_eal_devargs_parse fails, the rte_devargs has not yet been inserted
> in the global list. When jumping to err_devarg, the removal fails and it
> is not properly freed.
>
> Free the allocated rte_devargs if its removal failed.
>
> Coverity issue: 158658
> Fixes: 7e8b26650146 ("eal: fix hotplug add / remove")
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-03 20:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-03 12:34 [dpdk-dev] [PATCH] eal: fix leak in hotplug add on parse error Gaetan Rivet
2017-08-03 20:06 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).