From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 45E3D5907 for ; Tue, 24 Jun 2014 10:46:35 +0200 (CEST) Received: by mail-we0-f177.google.com with SMTP id u56so7991112wes.8 for ; Tue, 24 Jun 2014 01:46:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/o5CsGYYCjP7FSxefqFzXl0ALCmQi1UeZNMq5Up5JKs=; b=RTi8Pfnb+JxZ8DAqjUw7T01MhlvKiPXCpfr89aD+xk6oNax/F8vqpETS8KccHPsDBw TD+6ylH2EYytbfQqRwh4LoAkRPD0ZBmFvl/qwzOFgm9TKj9dIEyqiU8PIu0gfYB1TIuu 9DNqe4TTYnfajnTJz3YNpVAeOZWDXe8YWGGT1q+rOlHNCVrqmRfTlU3kx0NNkIGW9f/m 7BYVRgyrDu20OdOgfhuhab3nW45pBoBo/Ei/EAJ0XAgtmS9ZABBjf1RQCHvzcDVheMd0 FbFNSeY4xewQr3mcsPsfZ2u6M79xOqqxwguTHjDBe3c5LIDB7t5fjDB+LrwC/+wMveOm NEfA== X-Gm-Message-State: ALoCoQnARiJMBNeA6F+oTcxWrTHh3bs0g4rl96P0Et4mq8KftASk0kF9AQY2wgVFk8qRrtyYw9qV X-Received: by 10.180.98.163 with SMTP id ej3mr510465wib.9.1403599613480; Tue, 24 Jun 2014 01:46:53 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id i6sm41200136wiy.17.2014.06.24.01.46.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jun 2014 01:46:52 -0700 (PDT) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Tue, 24 Jun 2014 10:46:50 +0200 Message-ID: <2859281.xMAtdAgJn8@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1403587377-10287-1-git-send-email-jing.d.chen@intel.com> References: <1403587377-10287-1-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 08:46:35 -0000 Hi, 2014-06-24 13:22, Chen Jing D: > Fix a compile warning in shared code on 32-bits RHEL6.3/6.5. >=20 > Signed-off-by: Chen Jing D(Mark) In such case you should show the error message in the log. =09lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c:917: =09error: integer constant is too large for =E2=80=98long=E2=80=99 type= > --- a/lib/librte_pmd_i40e/Makefile > +++ b/lib/librte_pmd_i40e/Makefile > @@ -52,6 +52,7 @@ CFLAGS_SHARED_DRIVERS +=3D -Wno-missing-field-initi= alizers > CFLAGS_SHARED_DRIVERS +=3D -Wno-pointer-to-int-cast > CFLAGS_SHARED_DRIVERS +=3D -Wno-format-nonliteral > CFLAGS_SHARED_DRIVERS +=3D -Wno-format-security > +CFLAGS_i40e_lan_hmc.o +=3D -Wno-error I know we shouldn't modify base drivers. But this one seems to be an im= portant=20 error. In such case, we already modified base driver. Recently: =09http://dpdk.org/ml/archives/dev/2014-June/003498.html --=20 Thomas