Re: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net struct

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-12-18 14:55, ciara.loftus@intel.com:
> This patch fixes the issue whereby when using userspace vhost ports
> in the context of vSwitching, the name provided to the hypervisor/QEMU
> of the vhost tap device needs to be exposed in the library, in order
> for the vSwitch to be able to direct packets to the correct device.

Do you mean that vhost was not working at all?
Please precise the context and how it is critical.
More informations are needed to understand wether it should be merged in
release 1.8.0 or not.

> --- a/lib/librte_vhost/rte_virtio_net.h
> +++ b/lib/librte_vhost/rte_virtio_net.h
> @@ -96,6 +96,7 @@ struct virtio_net {
>  	uint64_t		features;	/**< Negotiated feature set. */
>  	uint64_t		device_fh;	/**< device identifier. */
>  	uint32_t		flags;		/**< Device flags. Only used to check if device is running on data core. */
> +	char			ifname[32];	/** Name of the tap device **/

Wrong comment style.

-- 
Thomas