From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 173157E7C for ; Thu, 18 Dec 2014 16:33:42 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id l15so2225461wiw.10 for ; Thu, 18 Dec 2014 07:33:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=aI01FMWROi8S5QDeTz8tV9zDGfqmI1KoKJklp6Ih69U=; b=Je/b45NcLLbyz3Lq3OtEI7a25Fnhw6C3TYsZeycuK80jiIYgk1RkrTk7PKSu8qq02H mAwUqb5QiSZleBhXFs15NxGvWuY6IJZ6oOfKXjapyYqWmTm1oMgf3SfFVVBzbNcJVroh Lbk2p/jP+Qtg/qHiasjiW3BHuRhBER9WTCB4kmw9SyRskob+4oEDqqirT/CB6a9TDYmZ SVvq1UwdZnFoPIgjANQlL/jHnabBkEknjp9udLOPCjs/yOnLQYyNvFBQESONzH3wX0HH qIwNTsdQ1vE4ijg5gznZ6u6qrqAmxCT5wK0f3Ky5pWHp33RFrZRS1l+3uGeJcmdIo8qP EoJw== X-Gm-Message-State: ALoCoQl7nYYl6LnvHCH7oATfyBNQXUtTWBGtxc6E/uA1PzjZZt1X1Jt8/OdCX0OZp5RmsZfKzzCs X-Received: by 10.181.13.42 with SMTP id ev10mr6179570wid.78.1418916821313; Thu, 18 Dec 2014 07:33:41 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ei5sm25177133wid.2.2014.12.18.07.33.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Dec 2014 07:33:40 -0800 (PST) From: Thomas Monjalon To: ciara.loftus@intel.com Date: Thu, 18 Dec 2014 16:33:14 +0100 Message-ID: <2861628.6qtiPmT13X@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1418914523-24530-1-git-send-email-ciara.loftus@intel.com> References: <1418914523-24530-1-git-send-email-ciara.loftus@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Anthony Fee Subject: Re: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 15:33:42 -0000 2014-12-18 14:55, ciara.loftus@intel.com: > This patch fixes the issue whereby when using userspace vhost ports > in the context of vSwitching, the name provided to the hypervisor/QEMU > of the vhost tap device needs to be exposed in the library, in order > for the vSwitch to be able to direct packets to the correct device. Do you mean that vhost was not working at all? Please precise the context and how it is critical. More informations are needed to understand wether it should be merged in release 1.8.0 or not. > --- a/lib/librte_vhost/rte_virtio_net.h > +++ b/lib/librte_vhost/rte_virtio_net.h > @@ -96,6 +96,7 @@ struct virtio_net { > uint64_t features; /**< Negotiated feature set. */ > uint64_t device_fh; /**< device identifier. */ > uint32_t flags; /**< Device flags. Only used to check if device is running on data core. */ > + char ifname[32]; /** Name of the tap device **/ Wrong comment style. -- Thomas