* [PATCH] devtools: fix bad substitution
@ 2023-07-11 7:16 Raslan Darawsheh
2023-07-12 16:19 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Raslan Darawsheh @ 2023-07-11 7:16 UTC (permalink / raw)
To: thomas; +Cc: dev
When running check-git-log, it showed a Bad substitution.
It is fixed by using tr to escape the open parenthesis.
Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses")
Cc: thomas@monjalon.net
Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
devtools/check-git-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 89544a2cc5..5c869b7683 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range |
sed -rn 's,.*: (.*<.*@.*>),\1,p' |
sort -u)
bad=$(for contributor in $names ; do
- contributor=${contributor//(/\\(}
+ contributor=$(echo $contributor | tr '(' '\\(')
! grep -qE "^$contributor($| <)" $selfdir/../.mailmap || continue
name=${contributor%% <*}
if grep -q "^$name <" $selfdir/../.mailmap ; then
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] devtools: fix bad substitution
2023-07-11 7:16 [PATCH] devtools: fix bad substitution Raslan Darawsheh
@ 2023-07-12 16:19 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2023-07-12 16:19 UTC (permalink / raw)
To: Raslan Darawsheh; +Cc: dev
11/07/2023 09:16, Raslan Darawsheh:
> When running check-git-log, it showed a Bad substitution.
>
> It is fixed by using tr to escape the open parenthesis.
>
> Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses")
> Cc: thomas@monjalon.net
>
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
> devtools/check-git-log.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
> index 89544a2cc5..5c869b7683 100755
> --- a/devtools/check-git-log.sh
> +++ b/devtools/check-git-log.sh
> @@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range |
> sed -rn 's,.*: (.*<.*@.*>),\1,p' |
> sort -u)
> bad=$(for contributor in $names ; do
> - contributor=${contributor//(/\\(}
> + contributor=$(echo $contributor | tr '(' '\\(')
tr was not working here, replaced with sed
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-12 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 7:16 [PATCH] devtools: fix bad substitution Raslan Darawsheh
2023-07-12 16:19 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).