[dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Dekel Peled]

Struct rte_flow_item_ipv6 will be modified to include additional
values, indicating existence or absence of IPv6 extension headers
following the IPv6 header, as proposed in RFC
https://mails.dpdk.org/archives/dev/2020-August/177257.html.
Because of ABI break this change is proposed for 20.11.

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7..5201142 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -110,6 +110,11 @@ Deprecation Notices
   break the ABI checks, that is why change is planned for 20.11.
   The list of internal APIs are mainly ones listed in ``rte_ethdev_driver.h``.
 
+* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to include
+  additional values, indicating existence or absence of IPv6 extension headers
+  following the IPv6 header, as proposed in RFC
+  https://mails.dpdk.org/archives/dev/2020-August/177257.html.
+
 * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly made
   ABI stable in the v19.11 release. The TM maintainer and other contributors have
   agreed to keep the TM APIs as experimental in expectation of additional spec
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Dekel Peled]

Kind reminder to all maintainers, please review and ack/comment.

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Monday, August 3, 2020 10:51 PM
> To: dev@dpdk.org
> Cc: jerinjacobk@gmail.com; stephen@networkplumber.org;
> arybchenko@solarflare.com; ajit.khaparde@broadcom.com;
> maxime.coquelin@redhat.com; olivier.matz@6wind.com;
> david.marchand@redhat.com; ferruh.yigit@intel.com
> Subject: [PATCH] doc: announce change in IPv6 item struct
> 
> Struct rte_flow_item_ipv6 will be modified to include additional values,
> indicating existence or absence of IPv6 extension headers following the IPv6
> header, as proposed in RFC https://mails.dpdk.org/archives/dev/2020-
> August/177257.html.
> Because of ABI break this change is proposed for 20.11.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7..5201142 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -110,6 +110,11 @@ Deprecation Notices
>    break the ABI checks, that is why change is planned for 20.11.
>    The list of internal APIs are mainly ones listed in ``rte_ethdev_driver.h``.
> 
> +* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to
> +include
> +  additional values, indicating existence or absence of IPv6 extension
> +headers
> +  following the IPv6 header, as proposed in RFC
> +  https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> +
>  * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly
> made
>    ABI stable in the v19.11 release. The TM maintainer and other contributors
> have
>    agreed to keep the TM APIs as experimental in expectation of additional
> spec
> --
> 1.8.3.1

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Thomas Monjalon]

03/08/2020 21:51, Dekel Peled:
> Struct rte_flow_item_ipv6 will be modified to include additional
> values, indicating existence or absence of IPv6 extension headers
> following the IPv6 header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> Because of ABI break this change is proposed for 20.11.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> +* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to include
> +  additional values, indicating existence or absence of IPv6 extension headers
> +  following the IPv6 header, as proposed in RFC
> +  https://mails.dpdk.org/archives/dev/2020-August/177257.html.

That's the same idea as VLAN item, but for IPv6 extensions.
We need to address the issues of variable header parts with rte_flow, so
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Andrew Rybchenko]

On 8/3/20 10:51 PM, Dekel Peled wrote:
> Struct rte_flow_item_ipv6 will be modified to include additional
> values, indicating existence or absence of IPv6 extension headers
> following the IPv6 header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> Because of ABI break this change is proposed for 20.11.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7..5201142 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -110,6 +110,11 @@ Deprecation Notices
>    break the ABI checks, that is why change is planned for 20.11.
>    The list of internal APIs are mainly ones listed in ``rte_ethdev_driver.h``.
>  
> +* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to include
> +  additional values, indicating existence or absence of IPv6 extension headers
> +  following the IPv6 header, as proposed in RFC
> +  https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> +

I agree that extra information is required in rte_flow_item_ipv6, but
I'm not
sure about proposed solution details. Taking it into account:

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Ajit Khaparde]

On Thu, Aug 6, 2020 at 5:30 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 03/08/2020 21:51, Dekel Peled:
> > Struct rte_flow_item_ipv6 will be modified to include additional
> > values, indicating existence or absence of IPv6 extension headers
> > following the IPv6 header, as proposed in RFC
> > https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> > Because of ABI break this change is proposed for 20.11.
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
> > +* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to
> include
> > +  additional values, indicating existence or absence of IPv6 extension
> headers
> > +  following the IPv6 header, as proposed in RFC
> > +  https://mails.dpdk.org/archives/dev/2020-August/177257.html.
>
> That's the same idea as VLAN item, but for IPv6 extensions.
> We need to address the issues of variable header parts with rte_flow, so
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Ori Kam]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> 
> Kind reminder to all maintainers, please review and ack/comment.
> 
> > -----Original Message-----
> > From: Dekel Peled <dekelp@mellanox.com>
> > Sent: Monday, August 3, 2020 10:51 PM
> > To: dev@dpdk.org
> > Cc: jerinjacobk@gmail.com; stephen@networkplumber.org;
> > arybchenko@solarflare.com; ajit.khaparde@broadcom.com;
> > maxime.coquelin@redhat.com; olivier.matz@6wind.com;
> > david.marchand@redhat.com; ferruh.yigit@intel.com
> > Subject: [PATCH] doc: announce change in IPv6 item struct
> >
> > Struct rte_flow_item_ipv6 will be modified to include additional values,
> > indicating existence or absence of IPv6 extension headers following the IPv6
> > header, as proposed in RFC
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> &amp;data=02%7C01%7Corika%40mellanox.com%7C0ae5d3ff8df34bc9304b08
> d83878ced6%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C6373214
> 38828980255&amp;sdata=XEgqNAncKKXhrcvI5b7nQbTwmKLdB4sPYeGVzGgPy%
> 2Fw%3D&amp;reserved=0
> > August/177257.html.
> > Because of ABI break this change is proposed for 20.11.
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ea4cfa7..5201142 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -110,6 +110,11 @@ Deprecation Notices
> >    break the ABI checks, that is why change is planned for 20.11.
> >    The list of internal APIs are mainly ones listed in ``rte_ethdev_driver.h``.
> >
> > +* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to
> > +include
> > +  additional values, indicating existence or absence of IPv6 extension
> > +headers
> > +  following the IPv6 header, as proposed in RFC
> > +
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177257.html&amp;data=02%7C01%7Corika%40mellanox.com%7C0a
> e5d3ff8df34bc9304b08d83878ced6%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637321438828980255&amp;sdata=aT3wab0eZiuac%2BC4BEG2
> 8nQlK7E5srbPqMZELpinWzQ%3D&amp;reserved=0.
> > +
> >  * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly
> > made
> >    ABI stable in the v19.11 release. The TM maintainer and other contributors
> > have
> >    agreed to keep the TM APIs as experimental in expectation of additional
> > spec
> > --
> > 1.8.3.1

Acked-by: Ori Kam <orika@mellanox.com>
Best,
Ori

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

[Thomas Monjalon]

> > > Struct rte_flow_item_ipv6 will be modified to include additional
> > > values, indicating existence or absence of IPv6 extension headers
> > > following the IPv6 header, as proposed in RFC
> > > https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> > > Because of ABI break this change is proposed for 20.11.
> > >
> > > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > > ---
> > > +* ethdev: The ``struct rte_flow_item_ipv6`` struct will be modified to
> > include
> > > +  additional values, indicating existence or absence of IPv6 extension
> > headers
> > > +  following the IPv6 header, as proposed in RFC
> > > +  https://mails.dpdk.org/archives/dev/2020-August/177257.html.
> >
> > That's the same idea as VLAN item, but for IPv6 extensions.
> > We need to address the issues of variable header parts with rte_flow, so
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Ori Kam <orika@mellanox.com>

Applied