From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0FFD91B1D6 for ; Mon, 21 May 2018 17:15:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7E9C7223E3; Mon, 21 May 2018 11:15:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 21 May 2018 11:15:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=JnsPzX9kbQCcSfDt+mtq5SA7pq s90aBI8xLVVkI3hf4=; b=NYSBSwqdf2xm+OvlcvLRkrM/658PE/SFO8FPqIC+Iz BJe+LsF9IzAeXM0zhd2AAk6CRaUEWjImY5F+KhcQpTfflb4chjxGYu9T/xjPuqoH 02Mu2TmvVUD4VnHMDtZSUjLj9m8BYMyjBGSGTEj2V71owX88c8wzzNgj3ABJ7Il+ s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JnsPzX 9kbQCcSfDt+mtq5SA7pqs90aBI8xLVVkI3hf4=; b=C5WAwoOs2staVCutWJ8bN/ njNeESV9HyUh9rZK1/W/sjmIBuLHxGN+LUUnGM1/cgIvC9deU+B+uBtyg8cSAVjv zCxlboAqVgxFsCkAEY62TWcstb+EbHkJv03H5csBH0qkrCRIxgN6t5BAfP8EB6vW Da2cD3p7jROSaAHDA9tCP94assmmRfBOfXxox1OnB8IoHyrM3vSjKtsp3SMOFVsy joZV8ynkyIynOnTY63JB0j+uRUhFORYpId5ezVZQ3YNXXAxiTxVPythVpf48MKqR 1LGLPa7AmCSYWPJmQxJd70NjgT7RIp6lJZ25AKaLuddvVCCeJYWtRXNbHlzQu/WQ == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (236.204.154.77.rev.sfr.net [77.154.204.236]) by mail.messagingengine.com (Postfix) with ESMTPA id AC7C0E4BF6; Mon, 21 May 2018 11:15:24 -0400 (EDT) From: Thomas Monjalon To: Daniel Shelepov Cc: dev@dpdk.org, "Iremonger, Bernard" , "Lu, Wenzhuo" , "Wu, Jingjing" Date: Mon, 21 May 2018 17:15:22 +0200 Message-ID: <2864743.lYVmoJq7xL@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CD2C8@IRSMSX108.ger.corp.intel.com> References: <20180504201209.2964-1-dashel@microsoft.com> <20180514211147.19784-1-dashel@microsoft.com> <8CEF83825BEC744B83065625E567D7C24E0CD2C8@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix burst stat reporting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 15:15:27 -0000 > > When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects > > burst statistics and includes them in the port stats report. The summary > > should include top 2 most frequent burst sizes, but there is a bug in finding > > the top-2. During the scan of burst size counts, the > > top-2 can change only if top-1 also changes. > > > > Added logic to update the top-2 if current burst size is larger than existing > > top-2, but smaller than existing top-1. > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Daniel Shelepov > > Acked-by: Bernard Iremonger Applied, thanks