From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB6C4429C9; Sun, 23 Apr 2023 22:09:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 792EC410DE; Sun, 23 Apr 2023 22:09:35 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id BC5B940A80 for <dev@dpdk.org>; Sun, 23 Apr 2023 22:09:33 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 672AD3200900; Sun, 23 Apr 2023 16:09:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 23 Apr 2023 16:09:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1682280570; x=1682366970; bh=NbncWCddVQdEnESSppxIQ6focz7FD8NiQ28 HS2TSnsU=; b=dKxfSlfz9uKArVrCxloXgW1w3lp4faQRKLJC/HNCy6LtaEenPrN /ECLuKDZ7Zf2GB2SGSp1ZYVjubcg5l2BJlMJCvMGt8VjwVqNcS6abxXScpXzA2NM KxjhlmKkQ/XJPXcjkYjxOKKoXwcSm7IRrRJzVwMbdv0tdZM9QgnA1pfqCWg/z5if +JN+0enkr5fvKWjAmurirr8kHsYRfcWMyeHbou79Ow2ZzsJgBt9cCd8+TBwbGsXO hYQw3NHg8dgp7aRYOFtj+uSWq9RX15jBBeEpJHtvBkcy2hdFVeh2EZGWQxnjKdXp PDbiGRT8T9dwDulUTx1LsPk3TEZlYDQpOfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682280570; x=1682366970; bh=NbncWCddVQdEnESSppxIQ6focz7FD8NiQ28 HS2TSnsU=; b=PM/bv0RnapSN9NoJ3VliIcHXmZfuSyxli+nMd+xQWLABvDTx6wu GL2IBRwNfBSbrWgwIX2TGwrbGUDNvFb0iX/QowjhA6O4L4wJ5UKQPByYQr3v2YCs uRkFlycNHl4/QwtE+el/0RYiJ6HLlnb8GnIP08QnG5p8n2O478llY2dQWsFUJJ+K KDsjNolBhY0MvkYnNKoS9GO5rSxzgOaz/W+qVVfmG0b8dcGokOig9aBNDmSpQYd9 Jj9F+Gt0pDEBjCyL6UNjNk5L4sGJzuMbzGBhuc4gUyTB++JSqJCb30frHfPxBi3s zIGzOWzcz0vXDMEdPvIp/QqHunXRhwqNVug== X-ME-Sender: <xms:eZBFZIpoGyQJJ29C0Deimi6LHm_9-OPPNVaa2LLONhYB0-WXXj0gMg> <xme:eZBFZOqaxVKVp9aiuGGUl46zGhFRgirCh29GgSzF72pKXK_2QutUqPUyOekMPyAEw vr7FMu4ernOqInq9w> X-ME-Received: <xmr:eZBFZNOJaXqoRfDaV6UzmdmTtIwLHlvezpneg7OXALyoFpTr7IWsnRhv-xIFriWfFMFovTFZo0TGL9VuU2XZ5wZHcQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtkedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:eZBFZP6sKj4OWXR9J87YLDWs3FnMXNLbSgjFM984LGLfn95ygXDaBg> <xmx:eZBFZH6gA8o1tsAWrHJ0GIbiNFU7zovYGsFooRR3g43v9eMWEW5EdA> <xmx:eZBFZPgly_6PeBzL_XgaIZ-N1L8QIfwEIiMbZPRXfFH-kAQ0Af5X_Q> <xmx:epBFZEjuAHV_lwmfhjL6V7keMBvNbVoxO-obfr5R7NDo-wxH_UCaAA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Apr 2023 16:09:29 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org Subject: Re: [PATCH v3 00/16] Enable lock annotations on most libraries and drivers Date: Sun, 23 Apr 2023 22:09:27 +0200 Message-ID: <2867499.SvYEEZNnvj@thomas> In-Reply-To: <20230404124840.1898-1-david.marchand@redhat.com> References: <20230224081642.2566619-1-david.marchand@redhat.com> <20230404124840.1898-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 04/04/2023 14:48, David Marchand: > This is a followup of the series that introduced lock annotations. > I reworked and made annotations work in what seemed the easier cases. > In most cases, I chose to convert inline wrappers around the EAL lock > API to simple macro: I did not see much value in those wrappers and this > is way simpler than adding __rte_*lock_function tags everywhere. > > A list of libraries and drivers still need more work as their code have > non obvious locks handling. For those components, the check is opted > out. > I leave it to their respective maintainers to enable the checks later. Some drivers require some effort to enable the lock checks at compilation: bnx2x, bnxt, cnxk, dpaa, enic, failsafe, hinic, hns3, mlx5 > FreeBSD libc pthread API has lock annotations while Linux glibc has > none. Until we get a proper abstraction for mutexes, the simpler is > to disable the check on FreeBSD. > > Maintainers, please review. Applied, thanks.