From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0885EA00C2; Wed, 2 Nov 2022 15:10:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E776C40223; Wed, 2 Nov 2022 15:10:31 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150045.outbound.protection.outlook.com [40.107.15.45]) by mails.dpdk.org (Postfix) with ESMTP id 2249740041 for ; Wed, 2 Nov 2022 15:10:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ScSKwhNkJvKo6xT3A7l6yjJa2ewlRVKalNbZ/V5X8r4qWQ+EZQ53Jd8CIqS8vDBdvHom+a/o29dE+qgFZ/K6M9lNzs+E6dJ8MvdTqtAPlOkk4lP/hXC1qoCn5U/oEIsy4dGXmnbw4UnDOaRWerPylL2VURvf1gp8VeX+JPrdjf6MC9fN0nv1siQGJOFk0GwBRWhAeEasPDBz5BS7m5ZtF6rOnYqWvOrHOMhqzuMAweMxoFdKCGFxLnf4/49252vrzcyEjPRuBSX8RE1MkaWD6zGJE3m5yoO6JNijufOiDRCoRwwUgXt5pzF8+76z7nwBYiECqL7YvQJfUHMUOwIdKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6V2hiUpxnSx9L371MXzJGEipysfm8cS+i4dutbIZmXg=; b=L4aHi7+jaO8lCIVYLIEtByZXqN6dWMimHNJ7UMvUFzT5m3IjgSu+RR8D60IvcH9aGS/IkmmAC3S03cHEcTwSRLNfmRa9oI0PnWIhRLoWa0XjKiSS4WyZruoxo8zhnlmvbVeKmQ4XMg+DH3m87MnHDgU4Y0kiY2EB7Cs/tRja3ub5rCbO97y0ut1jz7nFHCVR6Wh0ddiNDbpm7Qg8Sijzn/ycbRcnJCueIh0ZyFFQo3+6roOoA1lFYE90npOQ6IUAvSbOz33n6fUhwy8MPH9CCMSonIU0MTsFo2Z0ulqzLuur3JY4DU0cKQGyMLxAxApEW9Lp8iCEhsY0wonO3Q4nxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6V2hiUpxnSx9L371MXzJGEipysfm8cS+i4dutbIZmXg=; b=hqJIQxXlOWAhqsCM5GfxNWUfxvZtRYSPpsNZ7o49pr+/jimacbm4HWt+x6Uk9vOP+Qi+jLGuaX3y5URRoTOwrdIELDvY30qAuySIuf5sg+EMLZb6oWlYJaWWsuK/VLL10Zrn5iTmessrJvlJIkCSR8RuSptxpK2SkONFCdvEgc8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9064.eurprd04.prod.outlook.com (2603:10a6:20b:447::17) by GV1PR04MB9070.eurprd04.prod.outlook.com (2603:10a6:150:21::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 14:10:27 +0000 Received: from AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::400d:7e5d:9b0e:3d23]) by AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::400d:7e5d:9b0e:3d23%7]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 14:10:27 +0000 Message-ID: <28689c21-ee04-866f-a117-be0a073239b8@oss.nxp.com> Date: Wed, 2 Nov 2022 19:39:34 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH] examples/l2fwd: add check of Rx packets count To: Stephen Hemminger , Rahul Bhansali Cc: dev@dpdk.org, Bruce Richardson , thomas@monjalon.net, ferruh.yigit@xilinx.com, ajit.khaparde@broadcom.com, aboyer@pensando.io, andrew.rybchenko@oktetlabs.ru, beilei.xing@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com References: <20220525091327.4006824-1-rbhansali@marvell.com> <20220720103254.0a7a0c4e@hermes.local> Content-Language: en-US From: Hemant Agrawal In-Reply-To: <20220720103254.0a7a0c4e@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0197.apcprd06.prod.outlook.com (2603:1096:4:1::29) To AS8PR04MB9064.eurprd04.prod.outlook.com (2603:10a6:20b:447::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9064:EE_|GV1PR04MB9070:EE_ X-MS-Office365-Filtering-Correlation-Id: 58654750-a0dc-4bb0-e0d6-08dabcdbfd88 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ltz3421Ev54Z6SKM8pHBa7j0fcEGqosqJIw4TO3IOSLMPPshw1oXj093nSaLJ+M9eMcbYCTNP0Ib6w2PVvRJRjqdt0gG7HNlJG4pMCGCmBEedq0YYfNF0YeDhwRofdRrZSqlgFgNXPfFa17NmHPxA7iynPnPysUPMq4E0S3FHIZAoWvlDC6dUYPn/libixAvotXjawQq2uH10TdiqSSZuGFMSAcB6MzT4T4SIJe0zgaNkn1pYbGOVAjh11kLYtYzPsqHYeXQRZbWDOwAjbzY7SP8ucj5TXnlQx8UjTb3gYkyYm7dwVH5rtjbkPgJ9dMXFTuUhLDjG8oQdXVhCpnX/8nrNNbeivvo8bVdTe71PSrUs9/f1vSFLdMARNV8CV3aCC9w3Yysj6KWNZ791jxDbrdFPdLIkt+XnsUf1hTblgpvHVhXJ9AvN9sEY1FSQ0/Y3bnXJeX6zb1qvNMG9xZ4Kd991fHB6Y7UjFiGkv/OSMz7NZ7VKSqe2MXgeagC2hW6HvBCDVHCB30eNRx8vOnIPxWYNFbeGd4JAbbtG1KPp99SBDeYawbJ1SqbR1fx6nnOK51DbkfeYYTJiGQ5ass0w5CZlgDZg5FQSnysQgR2dJc3z40ecYd7JCBZUm74UPKWo4wLCXZgUDqIvOLYnahu3vSatiq7iukBMHf32qhp+3ViA1wz1E6NZo/bMYydngvlV4m9kC2gQKD+MYDSC8Fkb4hjQwArH3swXTiuqiL31aEsILkGs6rnbp7TbhYYgsEKH/GuHIz4GfcELSWCnzWsO/Oytv7QrlQeP3JHExH3ldI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB9064.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(376002)(136003)(451199015)(86362001)(31686004)(31696002)(38100700002)(4744005)(7406005)(7366002)(5660300002)(2906002)(7416002)(186003)(6512007)(2616005)(6666004)(6506007)(316002)(6486002)(478600001)(110136005)(41300700001)(66946007)(4326008)(8676002)(66556008)(26005)(8936002)(44832011)(66476007)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk42b1hBem5PUzIvTE5XeEpHajNxbjZ0TDh5MjN0NUd5cTJURTA3RjBscGpE?= =?utf-8?B?WFdpVndsdzdEOHRHeFBVd2JJTmZPQ0FSYy9jcDFoa1k4ZVVKOVBGTWxvbXc4?= =?utf-8?B?b2lBUEVkMTNTL0hxSlBxb2h0L250aG4wWXllVWcvWnErVjJ0QkNkcU5jTGNh?= =?utf-8?B?RG4xaW5IMHFqSjB1OGxKTHA4VUt2QjRaOGRhVURnWDJMcWJMdHcxZWNRU3N4?= =?utf-8?B?L2V4cVJFeXNoRHRDVEdtSlE2SzRBOFc2UXRDSnJBV1VsUkxUVWdqUkR4VlZ0?= =?utf-8?B?QWlkUWp0b2dBYlFPQlRIbDF1cTNVdW9JMUJ5eW9ld3pjNmpOb3YzY3YwRm02?= =?utf-8?B?bXRJL29TN0IyT0NDQkdCNW9uZms2aWtNalMwc3NpNFl2ZUVZd3N1MXNTSmht?= =?utf-8?B?SEh6clQwV3Y1ajhVUzd1cmNsQzRabkthVWhsbG83Uzg0WHpub29vdEZlUXdX?= =?utf-8?B?czBiNTJJb0NCQ3lQeG9OeTR4N0dwUmxUNkNNc002WkF6VnVqM0xZYWNmaWJ4?= =?utf-8?B?MG9DV1g0QVFFLzI3K1d5WVk3dWZGOFNGM1NNQXJBMHZsak9OV1ZseFZUcVI5?= =?utf-8?B?dTlZU3pKWXk5N2EwUXlacTNubWh2WVp0SUI0ckNHVzFiaStOM2JLK3c4NFBN?= =?utf-8?B?NG9wVjNTeW9nejRHZGkvV3pNNDRVMTNpYkh6S2JHUGFXRkd5cHM2NjdaRVNR?= =?utf-8?B?MUxzZ3h5OTVBUms4Undic3gzL3FzVU5XeUIxTE1FSUdQTFJWTFUrRDNhWXFv?= =?utf-8?B?RkFOQWk4M1pzN1laRFJGK1pNcjdJL2hyN1NmVWMzRVF1bXlOdlN0eXFta3Ur?= =?utf-8?B?SVltQThMWDhoRGJ4WUdtbW4wZFBtdjNIaVFlUkpiNW95eTY2UEZJT25BM3JR?= =?utf-8?B?dURWM2dNbFhCSExnbWYyaUxPYzc3VHM5bHdtSzMrbk1lUEhrcXhwL3BIR0hz?= =?utf-8?B?Y3ZvUUgxdjhGQVB1ZHZON29veU9NZmY0ODFjVCsvZXNlcnhiS09vOEVWenln?= =?utf-8?B?YjNIdFgwQ2txeC9kenl4c1hwWGRYZVlCeCtZc2tWbzFyQzdIVENNNE9lSHNt?= =?utf-8?B?bGVsVkNDWXpMUVQ2eldaeXNxblQwU1ppY3M5NldlWFcrTmY5VytWNEk3elVI?= =?utf-8?B?a29QS3BwOGUzcldVS1Vjb1luWjBnazV5aGx2OW50c1o4Y2VZMUFvbXovR05y?= =?utf-8?B?SktwbWxuZjNiOFRESjBqcTRud1dDNHY3blV1R0dMMUYwNHVzREZlN2I0NDh5?= =?utf-8?B?ZWg1RGoraGZKcEt2K240RENMRWY5Y1MvcjhncmxyT2RjMStUSGVObmRSWlkx?= =?utf-8?B?KzBOa1IyT0dNbGdwaSsvSHZvU2o3S1dmeW9uN0pVbDJNZ1BXOHdob2RJQjlF?= =?utf-8?B?b25pdGUxT3huSUZJajlmSC9uL1ZFRTZrekpKSmZYZmkvekhLYjRPT0dXa2NB?= =?utf-8?B?OTBhRnA0OEthUzJhRm44dWoydzlrTnhVMXFjTG5UcjlrSmhINHQ1N09qVFQr?= =?utf-8?B?VmoxTVJ5SnQ3UytaS2FLaEJSV3BCU3VVeFU4MmoxRm1kdFNRTXhmUUtZOFJy?= =?utf-8?B?T3ZBamRNMDYvQlE3bjVlYWhvZEJKVmk4MGJaWXFuTkE4UnpyZnIvRUtqcmw5?= =?utf-8?B?T2lkYUd1NkJFVDlQQXFSMnlsMERPSzA5L0FpdEZvcUcwaUVhTnh1RVNoREpT?= =?utf-8?B?U0swT1FuNDAwVkxYMHFRTHE1L0JYUDlDa2UvRVM5OFlmWVB4b1MrZmVWN05P?= =?utf-8?B?OGlHQmd6Q3lwWkRTNVpyc2tnSWxGejR1bU5ZcEFkZitjUFlEWmJWR0ZhQ1Vs?= =?utf-8?B?eS9PZmR4TEhLdDlmU1ZzcVlMSm1XQ05VZmFoY3Y0MnI3Ukpsd1UyTnJXeUpw?= =?utf-8?B?T1AxNHBlY2tLUHVMTXZkL0FVckYxTlVnWit4QnJtWlhOWXQ3c0VRTzZFdVJ0?= =?utf-8?B?Tjd5OTN5bTBSYkJaU3o0OFJSVnU1VzVjS0hxbCtnMnJlTVlrL0tSWjE0bEVw?= =?utf-8?B?OWMvbjlibUI0RHdGVElncHh0cFV3SGtSazc4NkF4OEZrc3h6OGkxWmNKRU01?= =?utf-8?B?OHZsWWFqQUNvYWhYRGlReWRCZCtoRnZ3Zm1QLzZqZDg5TEtvOVVSRHVVMjVx?= =?utf-8?B?UnNGZ3c4Q1pMeSthaElUZUQxaTNZeVlhbytGcnZaaTVReVg3SmVvUFBraG5Q?= =?utf-8?B?aXc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58654750-a0dc-4bb0-e0d6-08dabcdbfd88 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9064.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 14:10:26.8186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x2hwnQpXzhlvFLC8DCdqyan/Wsr0uYBz5DZ3mfPIQ3Fg3DkUJQ/sgnHQp9pwNiEag7gXvnkU90EW5I/Fc4bQ0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9070 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hemant.agrawal@nxp.com Errors-To: dev-bounces@dpdk.org On 20-Jul-22 11:02 PM, Stephen Hemminger wrote: > On Wed, 25 May 2022 14:43:27 +0530 > Rahul Bhansali wrote: > >> An additional check is added to avoid extra processing if >> receive packets are 0. >> >> Performance impact: with Marvell OCTEON TX2 platform, observed an >> improvement by ~14%. >> >> Signed-off-by: Rahul Bhansali > This makes sense. Could drop the unlikely() since in general unlikely > should be reserved for error cases. But doubt it matters at all. > > Did a quick check the other examples do similar thing already. > > Acked-by: Stephen Hemminger Acked-by: Hemant Agrawal