From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22561A0540; Mon, 20 Jul 2020 13:08:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 724712B9A; Mon, 20 Jul 2020 13:08:55 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 46E0C29CB for ; Mon, 20 Jul 2020 13:08:54 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200720110853euoutp01bb88ce30da9752093cff3648dde6ec40~jcVwe0_i23090730907euoutp01w for ; Mon, 20 Jul 2020 11:08:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200720110853euoutp01bb88ce30da9752093cff3648dde6ec40~jcVwe0_i23090730907euoutp01w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1595243333; bh=fTukG0SarXIEEkqiwSencje+UQn4pgnfmaN/ufZW6j8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=atVIhf6IF6ua3w81aBfDiJeyaQLTD34oaKXWVlw6u5QqAkTlydYrXcZzTMwl8OfGS fcXKTUjWINesCxwTKWi8P5wzCnCEgwj4N0879eT4a3pSKrZB9g102/TSLTK6XcgEwu ylb+3ZS5LqaiRmPYtOKKa/fNZCkUMgCG9H6R+jZU= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200720110853eucas1p2bf514c6cffa6d58bb5eb82a290d8ae2b~jcVwPCa422162321623eucas1p2P; Mon, 20 Jul 2020 11:08:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id DE.01.05997.54B751F5; Mon, 20 Jul 2020 12:08:53 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200720110852eucas1p1514e651105590befd1c9cbdab4db1ead~jcVv2-DTX0308203082eucas1p1W; Mon, 20 Jul 2020 11:08:52 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200720110852eusmtrp206c08fccc3e7509c40e3d0e925f726f0~jcVv2aFoe0142201422eusmtrp2R; Mon, 20 Jul 2020 11:08:52 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-a3-5f157b454486 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 91.64.06017.44B751F5; Mon, 20 Jul 2020 12:08:52 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200720110852eusmtip2f47e2e447f1162245ffcd91dac3d6c54~jcVvX1N-M1193711937eusmtip2j; Mon, 20 Jul 2020 11:08:52 +0000 (GMT) To: Kevin Traynor , dev@dpdk.org Cc: david.marchand@redhat.com From: Lukasz Wojciechowski Message-ID: <286a6f76-3047-2acc-61e3-83bdfb407535@partner.samsung.com> Date: Mon, 20 Jul 2020 13:08:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200720101908.12500-1-ktraynor@redhat.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42LZduzneV3XatF4g43ruC22r+his3j3aTuT xdpDH9gdmD1+LVjK6vF+31W2AKYoLpuU1JzMstQifbsEroyZZ48yF7zhrtj9+wBLA+Nmzi5G Tg4JAROJ/esnMnUxcnEICaxglFg5dzY7hPOFUWLD6wvMEM5nRok1Oy4BlXGAtVzZoQcRX84o se/IVKj2t0DtVx+xg8wVFrCU6LixnwnEFhEwlbh18jaYzSwgK3Hzz2RGEJtNwFbiyMyvrCA2 r4CbxPptl9lAbBYBVYkTO2+DxUUF4iTWv9zOBFEjKHFy5hMWEJsTaP7f48vYIWbKSzRvnc0M YYtL3HoyH+wgCYH/bBIf379jhnjURWL+/01QtrDEq+Nb2CFsGYn/O2EatjFKXP39kxHC2c8o cb13BVSVtcThf7/ZQP5nFtCUWL9LHxIUjhKtVzQgTD6JG28FIW7gk5i0bTozRJhXoqNNCGKG nsTTnqmMMFv/rH3CMoFRaRaSz2Yh+WYWkm9mIaxdwMiyilE8tbQ4Nz212CgvtVyvODG3uDQv XS85P3cTIzB9nP53/MsOxl1/kg4xCnAwKvHweiSJxAuxJpYVV+YeYpTgYFYS4XU6ezpOiDcl sbIqtSg/vqg0J7X4EKM0B4uSOK/xopexQgLpiSWp2ampBalFMFkmDk6pBsbaNO7VWZfuMLRr yTPPPmdcOOuiLMvS+axf6vvFhK8eWadrcmxNh/XnDrk7e5gVjCa6Xsg5xiIm/qd60TVTt18n BV/byd37tfzI9xy/wldbQiUWyKff8H8cG3RwY0Dfogs7lfhLXTICnzy4JF8Y+HF53GHbSxnx zOV5KvW9cZ5mMZlbDr2LYVFiKc5INNRiLipOBAC9zXMoGwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t/xe7ou1aLxBg/faVlsX9HFZvHu03Ym i7WHPrA7MHv8WrCU1eP9vqtsAUxRejZF+aUlqQoZ+cUltkrRhhZGeoaWFnpGJpZ6hsbmsVZG pkr6djYpqTmZZalF+nYJehkzzx5lLnjDXbH79wGWBsbNnF2MHBwSAiYSV3bodTFycQgJLGWU WNM1lwkiLiPx4ZJAFyMnkCks8edaFxuILSTwmlHi/MkQEFtYwFKi48Z+JhBbRMBU4tbJ22A2 s4CsxM0/kxkhZu5mlNh1dA0jSIJNwFbiyMyvrCA2r4CbxPptl8GGsgioSpzYeRssLioQJ7F8 y3x2iBpBiZMzn7CA2JxAy/4eX8YOscBMYt7mh8wQtrxE89bZULa4xK0n85kmMArNQtI+C0nL LCQts5C0LGBkWcUoklpanJueW2ykV5yYW1yal66XnJ+7iREYLduO/dyyg7HrXfAhRgEORiUe Xo8kkXgh1sSy4srcQ4wSHMxKIrxOZ0/HCfGmJFZWpRblxxeV5qQWH2I0BXpuIrOUaHI+MJLz SuINTQ3NLSwNzY3Njc0slMR5OwQOxggJpCeWpGanphakFsH0MXFwSjUwFpwtkGSYJXJg0+eT 1dsq1Jd0y1dMCDc/vOqOnt4TqYyNm2dkHysrjX62S6bZvmm9neT2L5/EdB6dtuS69VXdwJ9l 0ep658e5Wt8v+OdvOp10nFW8SLb6qMhTmSKz/78Fz+Wc+8KW1FRoqG58rHDh9dn/XvK9m+38 46XIt5Lk/5kTpv//urHIWImlOCPRUIu5qDgRAMiXxiCsAgAA X-CMS-MailID: 20200720110852eucas1p1514e651105590befd1c9cbdab4db1ead X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200720101926eucas1p2c179352d29ad42e7717430fa1a1bd972 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200720101926eucas1p2c179352d29ad42e7717430fa1a1bd972 References: <20200720101739.12427-1-ktraynor@redhat.com> <20200720101908.12500-1-ktraynor@redhat.com> Subject: Re: [dpdk-dev] [PATCH v2] test/eal: check invalid cpu value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 20.07.2020 o 12:19, Kevin Traynor pisze: > When using --lcores option, there is a limit of CPU_SETSIZE. > Currently that allows 0..1023 on Linux. > > Check it is caught when this limit is exceeded. > > Signed-off-by: Kevin Traynor > --- > app/test/test_eal_flags.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > index 4ee809e3d..b019656b2 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -528,4 +528,7 @@ test_missing_c_flag(void) > "--lcores", > "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"}; > + /* check an invalid cpu value >= CPU_SETSIZE */ > + const char * const argv30[] = { prgname, prefix, mp_flag, > + "--lcores", "3@" RTE_STR(CPU_SETSIZE) }; > > if (launch_proc(argv2) != 0) { > @@ -577,5 +580,5 @@ test_missing_c_flag(void) > launch_proc(argv24) == 0 || launch_proc(argv25) == 0 || > launch_proc(argv26) == 0 || launch_proc(argv27) == 0 || > - launch_proc(argv28) == 0) { > + launch_proc(argv28) == 0 || launch_proc(argv30) == 0) { > printf("Error - " > "process ran without error with invalid --lcore flag\n"); Now it's perfect. Acked-by: Lukasz Wojciechowski -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com