From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99917A04B5; Thu, 29 Oct 2020 12:34:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 081F2CA32; Thu, 29 Oct 2020 12:34:25 +0100 (CET) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by dpdk.org (Postfix) with ESMTP id 021B9CA2E for ; Thu, 29 Oct 2020 12:34:22 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 2A9A8A2F; Thu, 29 Oct 2020 07:34:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 29 Oct 2020 07:34:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= V/mEAOxAW4T+dZXDBV4LeJK+6SlffvRCvK21fSaJo1s=; b=HldI7DgImrdgNh3B egHz3BlASWFH4W3W9iLt79txXMa0yN4zDbOX9Zex81bLfRjoDK6LUbqi7EjpYyEG ePJJHkd+iy7QVhRiZPtx8hbc1UJfLsC2FvvP+Hp5MPkhTMKm/OmGUmsaYK7+zMYV 4Q89SN5GIzNWUTn6AqjyMRtE71Fh+e38Z05Kg/CmrJxMIQNCPm+cn7CGhk2YNkcq gzR+248SOrt0tpjD5qBCdVnDkPFoZYZYWoHPOp0ozTOdfsDC1fDmYcIPnTja7vCM jAVnNDahnTtw9q0YdFi36ytgwh08rMr3qZr83FuFznymRffF1M//KrwOSnjYIWnW fvTTgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=V/mEAOxAW4T+dZXDBV4LeJK+6SlffvRCvK21fSaJo 1s=; b=SsFukpTh5WrFA0Vk5CKEvW5CXXoWhF8cHrQ991m8B+YbrB5c1k97pU5Gb meJxAAILE1oBo4uKnPkzwHxVt2kL6kAONFRsBSDOezmQtMbCgD/aP9PXu5ZzJGvS mbCM50hyEIFLV/7wkbkbDQasDIA1+tbF7cFR8cAxFIO+JqTL9kLxG1c2oTBirpeX Hfe+A9Yj4xprzyQxnrNrrpheJ3CRq6B1HHjRPnEo+heksTAdWVeXcWH5VNuGq2Js ppsJcEbJG9I3Y8mnL0BjyVdpCgEs81Y7HFRROXTTCWHhDV9U9EYwDmEV/G28k6EB UO58D6RErY+G7LC36DD22hseSq6QQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 98ACB3064685; Thu, 29 Oct 2020 07:34:16 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, jerinj@marvell.com, viacheslavo@nvidia.com, Nithin Dabilpuram , Kiran Kumar K , Ray Kinsella , Neil Horman Date: Thu, 29 Oct 2020 12:34:14 +0100 Message-ID: <2870492.JuJT3Mpklu@thomas> In-Reply-To: <69cd6699-290f-102f-038a-f9fdde5874a1@oktetlabs.ru> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201029092751.3837177-11-thomas@monjalon.net> <69cd6699-290f-102f-038a-f9fdde5874a1@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2020 12:02, Andrew Rybchenko: > On 10/29/20 12:27 PM, Thomas Monjalon wrote: > > +/* variables are exported because this file is included in other drivers */ > > +extern uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag; > > +extern int rte_pmd_octeontx2_timestamp_dynfield_offset; > > + > > +static inline rte_mbuf_timestamp_t * > > +otx2_timestamp_dynfield(struct rte_mbuf *mbuf) > > +{ > > + return RTE_MBUF_DYNFIELD(mbuf, > > + rte_pmd_octeontx2_timestamp_dynfield_offset, > > + rte_mbuf_timestamp_t *); > > +} > > + > > May be ethdev should provide the inline function? It would mean exporting the offsets. And actually I think this field should not be restricted to ethdev.