From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 282953798 for ; Fri, 7 Apr 2017 16:47:46 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id u2so487040wmu.0 for ; Fri, 07 Apr 2017 07:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=NAXS2JPGN2iRlJJ1qNlP7wi6qGJ38cpsdHA2t9p+xg4=; b=mIifK00hLlu2QSKicR1VhPFz6sUuaZSW2o8/XuvHy9Nx14Z6f84WfP4JJzt20Wrnvy c5vK8jCLjT6kF4cY4fxiut8RJXNT6+Ju1o6ZS4jawY1QGpGN3oZPZrDUhstNU0EItwBB DjRro2O23+7A5hW7lcGYO/F9tUUsKB70wAzfozBOIB5BzXOzKJ15qUXqFsMpmuhHUdQz h6Q6S/MSshQvT9BKb+d3r+VwvzftP6biS8DGHX1UeJLNTinb5anv2KnKmvbT82XfrbRA d8P1ZW08mr4UO7BLnXpptqOiBgr7F1Qih1DteySKZ4Bwq/amTW3jiF8u/ArZBBdtzffq tNMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=NAXS2JPGN2iRlJJ1qNlP7wi6qGJ38cpsdHA2t9p+xg4=; b=fp1u9tdQK55UVzlGcjB/6boWX4OzA6EORH7Epr+A5CtZY4COxMpz9JDg7mgj5Dr6o9 MXQz7CeJUykq9aWZzscED5woIcyJAHw0S/2mubyCc9qodFK5JWAv4LCseOZ8C0Naj4or JReIbJc+m6ggcviOL6YI4RWpCUzgVmaiV5SriiKw/B7n1dGF5WzNvDu9Un7/S+PmYyc7 gPsLCM4ONTkHu6I4Diqn98+yeQCSX7S7teTB9rB77v+dJKpmwbdgOtGuwMdATqjQLpKU +aiFealcb25DNK8wCx1s9SR/hFL/Nqgv7apEK0svz/+Zr+nodipJyA/jxXQxvvDbcmwm ZTTw== X-Gm-Message-State: AN3rC/7Ls0OPeBu17gLQ7+vL/oJs8fYrbbjTak8pPdTzgxeyqA/elDdjnEexVbU9kUqbsYIx X-Received: by 10.28.54.151 with SMTP id y23mr2153742wmh.90.1491576466600; Fri, 07 Apr 2017 07:47:46 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d10sm6267076wrd.54.2017.04.07.07.47.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 07:47:45 -0700 (PDT) From: Thomas Monjalon To: Andriy Berestovskyy , Bruce Richardson Cc: dev@dpdk.org Date: Fri, 07 Apr 2017 16:47:45 +0200 Message-ID: <2875009.PBUn9ZmEvk@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <20170407122956.GA26192@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 14:47:47 -0000 2017-04-07 16:18, Andriy Berestovskyy: > Hey Bruce, > > On 07.04.2017 14:29, Bruce Richardson wrote: > > Is this entirely hidden from drivers? As I said previously, I believe > > NICs using ixgbe/i40e etc. only use the frame size value when the jumbo > > frame flag is set. That may lead to further inconsistent behaviour unless > > all NICs are set up to behave as expected too. > > You are right. If we take just Intel PMDs: some use the max_rx_pkt_len > only for jumbo frames (ixgbe), some always (i40) and some never (fm10k). > > What if we add to the max_rx_pkt_len description: "the effective maximum > RX frame size depends on PMD, please refer the PMD guide for the details"? I think the problem is not in the documentation but in the implementations which should be more consistent. > So with this patch we make rte_eth_dev_configure() clear and later PMDs > might change or clarify their limitations in the NIC guides. If I understand well, the inconsistency between drivers was already an issue before your patch. Your patch fixes an inconsistency in ethdev without fixing the drivers. We need to know if it is a good first step and if the drivers can be fixed later.