From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 2DAB3C3E2 for ; Mon, 20 Jul 2015 12:43:16 +0200 (CEST) Received: by wicgb10 with SMTP id gb10so22908590wic.1 for ; Mon, 20 Jul 2015 03:43:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FiE/cfCeNjF6zD/4oM7ZjC3AOsI4mlzNWgiGLROYV/Y=; b=DOVT8n9oBC2zl/7vijaG/+XHuWlbKXaILvy3U9irRaB7gjXrmeuo8MEvm7MxkGm0s1 8Kc7G+rJVYpuqb8rfB20stHQVQhaakrmdtfJARGbYmVSeDnQCfXoa2m5bY9ynrWlwYRn r8mcR8Ybe6zwktBjlMQ3UQWLtmQoyUZQbyN2fw+JJUxOKIzcaao1AFwD5mHbSlL93FKN N72deGGkTQg14NOnhEIUjlfnvWmSkcSZk9UfDJGmKQXlXvM5YtqnNC//O770HMhcT1ei Zk++HR8JL8KxHnkKBgn1B9avfDOlM0OOLx81wGprgC/eE10l0RZjGn+8V//J1cqtQ6ej LsFg== X-Gm-Message-State: ALoCoQlJZHea5xKMG50o6+w/kmS7PUKSLxWgigUa5YrDer+w4r92cPbmk/SpgddiADv93t/PifJQ X-Received: by 10.194.7.97 with SMTP id i1mr56156275wja.107.1437388995955; Mon, 20 Jul 2015 03:43:15 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ul1sm31354816wjc.30.2015.07.20.03.43.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jul 2015 03:43:14 -0700 (PDT) From: Thomas Monjalon To: "Ouyang, Changchun" Date: Mon, 20 Jul 2015 12:42:04 +0200 Message-ID: <28751942.NtB1joDEOR@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1435736930-26737-1-git-send-email-changchun.ouyang@intel.com> <82F45D86ADE5454A95A89742C8D1410E01D7DBAF@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2015 10:43:16 -0000 2015-07-20 06:18, Ouyang, Changchun: > Another thing burst into my thought. > Can we think more about how to setup a mechanism to block those patches which causes critical regression issue? Yes. Non-regression tests are needed. As it must be done with many hardwares and many configurations, it must be a shared effort. As a first step, you can run some automated tests by yourself and *manually* raise errors on the mailing lists. When it will work well, we could discuss about gathering test reports in a clean distributed way. Note that this topic is already a work in progress by few people and a public proposal should be done in few weeks. > I did review that patch before, but fail to realize it will break the basic function of virtio PMD, it is my bad. > (Can I send the nack to that patch even after it has been merged into dpdk.org?) After being approved and merged, a nack has no effect. Having a revert approved is the good way. > After that, we find that in our testing cycle, we spend time in investigating that and root the cause, and sent out > the fixing patch on July 1. Keeping virtio basic functionality broken more than 20 days is bad thing for me. It wouldn't be so long if these 3 simple things were done: - use a better title: "virtio: fix Rx from Qemu" instead of a not meaningful "fix the vq size issue" - cc Stephen (I did it later) who did the original patch you wants to revert - have an acked-by from Huawei Xie who commented the patch > If we can run a regression automation test with every patch set sent out to dpdk.org, and put those patches breaking any test cases > Into failing-list and notify author, reviewer and maintainer, all those things should be done before theirs being merged, then it will > prevent from merging the erroneous patch into mainline, and thus reduce most reverting patch. As explained above, it is planned and you can start running you own local test machine. But please do not spam the mailing list with automated mails from these tests.