From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 680F8A00BE; Thu, 10 Feb 2022 16:12:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A0D042714; Thu, 10 Feb 2022 16:12:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EB293426EE for ; Thu, 10 Feb 2022 16:12:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644505934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j493JyS1h5Vw3HDCDRbYe1w5f0p4GwFzd5ztiCBP4ao=; b=CYx/plrRjuvwKXRx50aFqZfgknb5hIYkj6hrKiylMyMFv7YJCVQioUztBMN9kOc4kzAagW 8zMdj9xHEwPVbridabnp/EfUgldkrfi+avgerRtiP+ac4gvG8Mh1vIARHkIW3vPT6+9l5c mNyWUpbofzXTdzm7x5wqCTdw5y0xI44= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-AkKyN1UhOJChsvo0CJNItg-1; Thu, 10 Feb 2022 10:12:11 -0500 X-MC-Unique: AkKyN1UhOJChsvo0CJNItg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DB7383DD27; Thu, 10 Feb 2022 15:12:10 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90B6077440; Thu, 10 Feb 2022 15:12:07 +0000 (UTC) Message-ID: <28755287-b245-bd44-908b-3072a26654e9@redhat.com> Date: Thu, 10 Feb 2022 16:12:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] vdpa/sfc: fix null dereference To: Weiguo Li , vsrivast@xilinx.com Cc: dev@dpdk.org References: From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/29/22 19:07, Weiguo Li wrote: > Fixes: b11961363b4a ("vdpa/sfc: support device configure and close") > > Signed-off-by: Weiguo Li > --- > drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c > index c4ce4474ef..b3d9b6cd56 100644 > --- a/drivers/vdpa/sfc/sfc_vdpa_ops.c > +++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c > @@ -611,7 +611,7 @@ sfc_vdpa_dev_config(int vid) > > ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev); > if (ops_data == NULL) { > - sfc_vdpa_err(ops_data->dev_handle, > + SFC_VDPA_GENERIC_LOG(ERR, > "invalid vDPA device : %p, vid : %d", > vdpa_dev, vid); > return -1; > @@ -666,7 +666,7 @@ sfc_vdpa_dev_close(int vid) > > ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev); > if (ops_data == NULL) { > - sfc_vdpa_err(ops_data->dev_handle, > + SFC_VDPA_GENERIC_LOG(ERR, > "invalid vDPA device : %p, vid : %d", > vdpa_dev, vid); > return -1; Applied to dpdk-next-virtio/main with fixing the title and cc'ing stable. Thanks, Maxime