DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <phil.yang@arm.com>
Cc: dev@dpdk.org, david.hunt@intel.com, reshma.pattan@intel.com,
	gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread
Date: Fri, 05 Apr 2019 01:24:52 +0200	[thread overview]
Message-ID: <28787746.rR50tbZ9jN@xps> (raw)
In-Reply-To: <1554274796-23258-2-git-send-email-phil.yang@arm.com>

Hi,

03/04/2019 08:59, Phil Yang:
> The current implementation using the '__sync' built-ins to synchronize
> statistics within worker threads. The '__sync' built-ins functions are
> full barriers which will affect the performance, so add a per worker
> packets statistics to remove the synchronisation between worker threads.
> 
> Since the maximum core number can get to 256, so disable the per core
> stats print in default and add the --insight-worker option to enable it.
[...]
> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>

There is an error with clang:

examples/packet_ordering/main.c:82:57: error:
	suggest braces around initialization of subobject
static struct wkr_stats_per wkr_stats[RTE_MAX_LCORE] = {0};

  parent reply	other threads:[~2019-04-04 23:24 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03  9:49 [dpdk-dev] [PATCH] packet_ordering: replace sync builtins with atomic builtins Phil Yang
2019-03-28 18:42 ` Thomas Monjalon
2019-03-28 18:42   ` Thomas Monjalon
2019-03-29  1:34   ` Phil Yang (Arm Technology China)
2019-03-29  1:34     ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 0/3] example and test cases optimizations Phil Yang
2019-03-29 10:56   ` Phil Yang
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-03-29 10:56   ` Phil Yang
2019-03-29 16:39   ` Pattan, Reshma
2019-03-29 16:39     ` Pattan, Reshma
2019-03-30 16:55     ` Phil Yang (Arm Technology China)
2019-03-30 16:55       ` Phil Yang (Arm Technology China)
2019-04-01 12:58       ` Pattan, Reshma
2019-04-01 12:58         ` Pattan, Reshma
2019-04-02  3:33         ` Phil Yang (Arm Technology China)
2019-04-02  3:33           ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-03-29 10:56   ` Phil Yang
2019-04-01 16:24   ` Honnappa Nagarahalli
2019-04-01 16:24     ` Honnappa Nagarahalli
2019-04-02  3:43     ` Phil Yang (Arm Technology China)
2019-04-02  3:43       ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 3/3] test/ring_perf: " Phil Yang
2019-03-29 10:56   ` Phil Yang
2019-04-01 16:24   ` Honnappa Nagarahalli
2019-04-01 16:24     ` Honnappa Nagarahalli
2019-04-03  6:59 ` [dpdk-dev] [PATCH v3 0/3] example and test cases optimizations Phil Yang
2019-04-03  6:59   ` Phil Yang
2019-04-03  6:59   ` [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-04-03  6:59     ` Phil Yang
2019-04-04 23:24     ` Thomas Monjalon [this message]
2019-04-04 23:24       ` Thomas Monjalon
2019-04-08  4:04       ` Phil Yang (Arm Technology China)
2019-04-08  4:04         ` Phil Yang (Arm Technology China)
2019-04-03  6:59   ` [dpdk-dev] [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-04-03  6:59     ` Phil Yang
2019-04-04 15:30     ` Honnappa Nagarahalli
2019-04-04 15:30       ` Honnappa Nagarahalli
2019-04-03  6:59   ` [dpdk-dev] [PATCH v3 3/3] test/ring_perf: " Phil Yang
2019-04-03  6:59     ` Phil Yang
2019-04-08  3:02 ` [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations Phil Yang
2019-04-08  3:02   ` Phil Yang
2019-07-04 20:15   ` Thomas Monjalon
2019-07-05  3:19     ` Phil Yang (Arm Technology China)
2019-07-08 14:38   ` Thomas Monjalon
2019-04-08  3:02 ` [dpdk-dev] [PATCH v4 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-04-08  3:02   ` Phil Yang
2019-04-08  3:02 ` [dpdk-dev] [PATCH v4 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-04-08  3:02   ` Phil Yang
2019-04-10 14:05   ` Hunt, David
2019-04-10 14:05     ` Hunt, David
2019-04-11 11:31     ` Phil Yang (Arm Technology China)
2019-04-11 11:31       ` Phil Yang (Arm Technology China)
2019-04-08  3:02 ` [dpdk-dev] [PATCH v4 3/3] test/ring_perf: " Phil Yang
2019-04-08  3:02   ` Phil Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28787746.rR50tbZ9jN@xps \
    --to=thomas@monjalon.net \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).