From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1A31A0A0E; Thu, 29 Apr 2021 09:48:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 639804067E; Thu, 29 Apr 2021 09:48:25 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 5A81A40141 for ; Thu, 29 Apr 2021 09:48:24 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 0B8ED58074E; Thu, 29 Apr 2021 03:48:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 29 Apr 2021 03:48:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= JxNj1mHunFYOd98XOzrRAOPGixO6IpLMwT8nxpNQKRs=; b=G1BXqdeSMV89sTWv 3vOh+WwZ/X5FyTH7zTP2I0845fWanneDrxGiuno7VKuKTZgBVvRowgnM/jQgdrhy BFBTEka7sXKK3/4CLMCMv3mGGGyRCKy51pBTy6/ApsYHaINS0Tj4iJ5N6rmr3lbD aUXUx5SwyGpwvAjckpCSI8DQQtGfVOiUzAdfm7sHQJVEMdw+5dAqyjE7H9Ejx2w+ gSKUYMom7ZcPPRTUhZ6xYy8X0B/GM4P8xc6lHTIxygV3/F4Sz3dZfyFUzQX748Zv fJ6Vyc7tcnJCHrL6fHjLAYFq85lMDvz3G1BnpnD+7cCFZ0HEzABpO4XCU8EvuqbI LGv/zA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JxNj1mHunFYOd98XOzrRAOPGixO6IpLMwT8nxpNQK Rs=; b=YcjkveysDTQJzEiMsAcfR5UC0mgh5K1DniVnxQjWXhzl4DBqmnd46VWCO TO0hYjdo06P0Nin///Yr0Mp4t25Z8bnJL4MdlF5CPyyWdrgb/A7ZdzoLoHM0m3fe lUmUvueEVpSUKbimphAN044pGHwDkViC9gKLqiEDpJ+aR9BZUaDCgJKz3tLr0LSl I0guuSLhGsnaG1Y6G8Dae39grLJFT57tGvKzgUEaB4VDkaZmbntHYy6MrFKaVMIO /AQncHv0RBbpykRjzNeZ5BqjJQNRmXNV3ILD3Czd/i6MnNM7+JdpQLSpFaTH5nfE oYUADrvhd3gj7yoBsdJ43OnY0S34g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvfedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Apr 2021 03:48:22 -0400 (EDT) From: Thomas Monjalon To: Narcisa Ana Maria Vasile , Dmitry Kozlyuk Cc: dev@dpdk.org, khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Date: Thu, 29 Apr 2021 09:48:20 +0200 Message-ID: <2879074.f3q8zTBTW7@thomas> In-Reply-To: <20210429035034.570f33e3@sovereign> References: <1617057640-24301-2-git-send-email-navasile@linux.microsoft.com> <1617413948-10504-3-git-send-email-navasile@linux.microsoft.com> <20210429035034.570f33e3@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 02/10] eal: add thread attributes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/04/2021 02:50, Dmitry Kozlyuk: > 2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > > +int > > +rte_thread_attr_init(rte_thread_attr_t *attr) > > +{ > > + if (attr == NULL) { > > + RTE_LOG(DEBUG, EAL, > > + "Unable to init thread attributes, invalid parameter\n"); > > + return EINVAL; > > + } > > This message doesn't add value for debugging: caller already knows that > attribute initialization failed (that's what function attempts to do) and > that the parameter is invalid (EINVAL). > I'd remove it (same applies below). > If you find it useful to keep, an extra indent missing (also more below). Recently in ethdev we added more messages like this for NULL parameters. I agree it is not a lot useful but I understand that lazy developers may like it ;)