From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58BCDA0544; Fri, 23 Sep 2022 10:57:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01055400D7; Fri, 23 Sep 2022 10:57:55 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 576E54003C for ; Fri, 23 Sep 2022 10:57:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id ACD2132008FA; Fri, 23 Sep 2022 04:57:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 23 Sep 2022 04:57:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663923470; x= 1664009870; bh=fab/nNBal/5oJcP4xa+HfaEYn+NAy5dbLq2Apzx/cSQ=; b=y j/zbxTgKeI8wLb7OXJJFAMlD2ALaz37ZQIQi9u2C5XxMfHURmzNFAdMSVp509t75 3samh8HDL5m4zG5bvlEtjWahydaAd81xxYwLHv2BsyoAYfDhBJ4R7+povCdnbBV8 +/hxXlwuXvM5/PQgU6zYnUpNVl6mzyA5qmqYMjIwQsGrw/KQyKrHoRV/Vn/+uECZ nfV6noqIPHlefb6W6SJCXAhUdaAdse+i/MXiQn/qJ+dj/WozmWwdOaAwMsyfad5z sRKipOrQQFElY5zBOyAbJJRToqZAN0rl8cAWbaA9KZ8wfxPJJ+tqwQBBwlqG7Sea 8I6+bVKg6caYucilPzUzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663923470; x= 1664009870; bh=fab/nNBal/5oJcP4xa+HfaEYn+NAy5dbLq2Apzx/cSQ=; b=n MwDfbddC0C6l7NpKQqfptuyJq0wgMJckN1ksb/GgHcdH+aPIWGkuWOdr5kEcfJHq muKKqOPwriEPInK3Z+4bRUU4KCWqnG70LUPJ9ZBalR2Qfizd6Hu37hGM/B+cpfoX li0xNRC+dhHaeBz+E4vuZTbKN6za6FVaUOSWvKISFvapeY8jBxtGysoKmleNDVFS gBdD/9QIrk639KjcpRTsf8s/eu7S1PAUGj3uM9Mpig97W/5FjSafDlU0GNK78piM C9dGoHBRGnccOPArIIbtK/5jWdBbV/9/+XfSIMK1nxH+C2FnDR+D43Ig9JEEGjTk ADCEaKI6/ZLem/pulsPxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefiedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Sep 2022 04:57:47 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , Tyler Retzlaff , David Marchand Cc: dev , Bruce Richardson , Kevin Laatz , Parav Pandit , Xueming Li , Hemant Agrawal , Sachin Saxena , Rosen Xu , Stephen Hemminger , Long Li , Chas Williams , "Min Hu (Connor)" , Matan Azrad , Ray Kinsella , Ferruh Yigit , Andrew Rybchenko Subject: Re: [RFC PATCH 11/11] bus: hide bus object Date: Fri, 23 Sep 2022 10:57:45 +0200 Message-ID: <2880087.VdNmn5OnKV@thomas> In-Reply-To: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220709092803.433e6644@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/09/2022 10:49, David Marchand: > On Sat, Jul 9, 2022 at 6:28 PM Stephen Hemminger > wrote: > > > For now, I'll post a v2, extending the series to other internal objects. > > > We can conclude on this topic during 22.11. > > > > If you get chance to deconstruct API, switching to a numeric index > > is safest similar to what Tyler suggested. Think of ethdev port number > > and Posix file descriptor model. The advantage of an index is that > > it can be validated more easily by the code that is called. > > This is still a heavy change in the APIs. > The deprecation notice did not mention such change, and I don't think > many people are aware of this suggestion. > This would need more discussion but I don't want to block the series > on concluding on this question. > > So I am for going ahead with the series in its current form. I agree that changing the object type would too much heavy. The goal of this series is to hide the object, not changing the way we refer to it. I understand the compilation check is stronger on a plain object than on a pointer, but I don't think this benefit is worth changing some basic API of DPDK. It seems our users prefer having less API change.