From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5A7EA0C41; Fri, 27 Aug 2021 10:21:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A17C640DF4; Fri, 27 Aug 2021 10:21:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 547034067C for ; Fri, 27 Aug 2021 10:21:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630052461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9w0K4zZZZE/kc83yhFcneDjZ1t+HXLZLsUk6O1f2AhM=; b=hPKRq0+pUGsytTUvt/GmteglVvBzzPV1nAEl5KhDM+yFNl0znpjZOgLrjDhLYKhxr6Tse/ xmX3F5Xd+g+XfjJRE5yxGLyKAJZLiHcup2hV5XG3IUo4quYyrNUzINoziCbYJDzMzjKNfv l+E8KJfMUpP6QSKp7S11IzKIX+i1rwc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-5tf67-gNNxuFn7oe6QW1IA-1; Fri, 27 Aug 2021 04:21:00 -0400 X-MC-Unique: 5tf67-gNNxuFn7oe6QW1IA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 222DE1008066; Fri, 27 Aug 2021 08:20:59 +0000 (UTC) Received: from [10.39.208.15] (unknown [10.39.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3729F4180; Fri, 27 Aug 2021 08:20:54 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com, david.marchand@redhat.com, Cheng Jiang References: <1629463466-450012-1-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: <28803bbb-9a2d-0694-903e-cdc8fafedcbf@redhat.com> Date: Fri, 27 Aug 2021 10:20:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1629463466-450012-1-git-send-email-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jiayu, Thanks for working on it! On 8/20/21 2:44 PM, Jiayu Hu wrote: > Copy threshold is introduced in async vhost data path to select > the appropriate copy engine to do copies for higher efficiency. > However, it may cause packets out-of-order, and it also causes > data path performance unpredictable. > > Therefore, this patch removes copy threshold support in async vhost > data path. > > Signed-off-by: Jiayu Hu > Signed-off-by: Cheng Jiang > --- > doc/guides/prog_guide/vhost_lib.rst | 7 - > examples/vhost/main.c | 22 +- > lib/vhost/rte_vhost_async.h | 22 +- > lib/vhost/vhost.c | 6 +- > lib/vhost/vhost.h | 1 - > lib/vhost/virtio_net.c | 439 +++++++++--------------------------- > 6 files changed, 116 insertions(+), 381 deletions(-) > It looks good to me, and simplifies the code a lot. Reviewed-by: Maxime Coquelin Thanks, Maxime