From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 1D90B2C09 for ; Wed, 23 Mar 2016 16:57:26 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so240076439wml.0 for ; Wed, 23 Mar 2016 08:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=/hwxqXVpEqlW48pRyQu0sZGlujDg3LxTAXAQdcm2vbc=; b=QLXtoXdz/HmhEA390XC/E1Pb+K5WFrPOBjVfpJ0C1oD+N/mKo40RlMS4RUw2e8WTl/ EKZi6aUYZbx05s/PiDayHGBx507KRKjBvEryXwhYeCicfkYzdU/Bwucv0QWrVXqWzhX0 wrNzn4Ft9Toazoa0PRdm9xD0D6GVNsOPo4wThab5zgvWZlV3X9zNumyTRXtX8TYQgubQ S084L8qUipBJ9hUVRX20gDCjVsWZaKFJbGGZuCi/2Uy6hsTOkB0h7DLe1ih0rZEMkWET MG6mgWWgnYGHFSWCkNPUr0+Ds3htCzoAGTNYCJW/Sh6u+tDV52H4dcfTvi41ahz8n+Hi KQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=/hwxqXVpEqlW48pRyQu0sZGlujDg3LxTAXAQdcm2vbc=; b=M7mDdeR9bI9WpOBsmiNwki10TRjOuZtvsnVtjou9vj3R5lkXlWFf3X4meztHT+FIcp 9n9rXoq9C+ZANlDERnubTFjx369rpKxzS1v+ru+YW/g3JXMpFTFsqUzSFoMc4fdnZd+U 1jqcmfGMRfb/lR8lUz53PM6C41vjDEFyJxeISV9Xd/RuzhvI8CyI61DOSEgJpu9tD2kP fqQXQT8MMicK0emhYOui+fTRj/u8BCyKUsLHOqBOhuUGKYo4IqcqCCuJAKSH8ahNA71e Iu0ZByAqJ5F3JvkT+yXG4xZDoc9nPsOegr9ubHwuOaU3KkEMwjI7d9vXOD3av9kB6Hdp qZGQ== X-Gm-Message-State: AD7BkJK63OpyuHSu0JlVPZA93KA2mNxuY6nIWaXxeLukEY3kmqAtCTOKilqsIlOdGXvfukyP X-Received: by 10.194.89.2 with SMTP id bk2mr4272206wjb.39.1458748645973; Wed, 23 Mar 2016 08:57:25 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id j18sm23004243wmd.2.2016.03.23.08.57.24 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 08:57:25 -0700 (PDT) From: Thomas Monjalon To: Yong Wang Cc: dev@dpdk.org, "Xu, Qian Q" , "Ding, HengX" , Stephen Hemminger Date: Wed, 23 Mar 2016 16:55:43 +0100 Message-ID: <2884173.JGZgsZNF00@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <835F13EC-4482-40D1-8A38-F994B82EC68E@vmware.com> References: <6EBE0505FB6FBE47AB600802285284524B853B86@CDSMSX101.ccr.corp.intel.com> <82F45D86ADE5454A95A89742C8D1410E0320E103@shsmsx102.ccr.corp.intel.com> <835F13EC-4482-40D1-8A38-F994B82EC68E@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] testpmd could not start up with vmxnet3 port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 15:57:26 -0000 2016-03-23 05:57, Yong Wang: > From: Ding, HengX > > Testpmd will fail to start up with vmxnet3 port. [...] > Currently vmxnet3=E2=80=99s default_txconf.txq_flags is set to the fo= llowing, which is used by testpmd > as there is no explicit txconf passed when initializing tx queue: >=20 > dev_info->default_txconf.txq_flags =3D ETH_TXQ_FLAGS_NOMULTSE= GS | > ETH_TXQ_FLAGS_NOOFFLO= ADS; In vmxnet3_dev_tx_queue_setup: if ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOXSUMS) !=3D ETH_TXQ_FLAGS_NOXSUMSCTP) { PMD_INIT_LOG(ERR, "SCTP checksum offload not supported"); return -EINVAL; } It means we cannot disable TCP or UDP checksum offload. ETH_TXQ_FLAGS_NOXSUMS =3D NOXSUMSCTP + NOXSUMUDP + NOXSUMTCP I think it should be: if ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOXSUMSCTP) !=3D ETH_TXQ_FLAGS_NOXSUMSCTP) { > With the referred patch that introduced l4 cksum offload, we should u= pdate the default txq > flags check accordingly. Heng, can you post the error logs to confir= m this is indeed the cause > of the error you reported? The default conf is ETH_TXQ_FLAGS_NOOFFLOADS (=3D NOVLANOFFL + NOXSUMS)= . Yes you can update the default conf, *and* fix the check above. > Related to this, I saw that the check for NOMULTISEGS has been remove= d and the check for > NOVLANOFF was never implemented. Should we just remove the offload f= lags check as well > as I don=E2=80=99t see much value of this check. Basically we know t= hat the device does not support > certain offload and we have to set those flags to let the device init= ialize. But doing this does > nothing to prevent users to request these non-supported offload. I a= lso saw another thread > discussing better device capability APIs and hopefully this will not = be needed then These checks are important to throw an error if an offload is requested= but not supported.