From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F79C42CF9; Mon, 19 Jun 2023 15:30:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4A2D40E0F; Mon, 19 Jun 2023 15:30:22 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 9AD9740DF8 for ; Mon, 19 Jun 2023 15:30:20 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 44C4A3200973; Mon, 19 Jun 2023 09:30:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 19 Jun 2023 09:30:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687181418; x=1687267818; bh=nDWfOhsvdQGVmL71/LyG8tnYNGJ7pWQHcgu x3wCzjjA=; b=KQ1m6k8VJiWsTpweI7YUEpjLmORc7F6aRU8sBcg3JwHPDFd/ntR Xoiyd0LTN2HknxcHDs1qj/uC2Z6d5wet7ZAtkXDYR/M2XjAAe4cakpHxq9G8qG9n FuYlCVqoUaM7zx3tUvq8kppPS//f3i4nD4OKd5l/yuWh6xy9+tGi3+x8jYlMK+/n S/tNceti7kbZiqUSwE2pL1Fk/RsKjptR+qIEfWgiNLMEsASGHJ6EiTxTHk+qv1Aj FGQ5uwzDyk2KpbYv/RoeK8BPub1tTbuB9J47fHb/gHzo1IT4/fENzI3/36uygnbA Z0R/nYSJpp7s1qsVFp/v29hLinolFIZGLMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687181418; x=1687267818; bh=nDWfOhsvdQGVmL71/LyG8tnYNGJ7pWQHcgu x3wCzjjA=; b=QRhkVxrbsbN0Q+9U72/F8tV87zMyssSljLL9vIlmdPt5bpQ3qKa w6keu7Er74b/PnTOHo+S/SvR1wOAVSJdumuM7UzNOja7rJXYqaOe2VB1tUWXgTWV ROErscpLIHS9hU4GYp0hndo7JSKseN/KvCb1MzNbTvwKu8FbJK35ZAf+Wu8Jw3yW YfweENnoS3Pgf/AZBs1vRa8UMs3/1w5R/yL/Ew/NDkQZK/GCLhFWvQfC8ZlfgYEL D06KsXstqGMiMtiV1S4yJJaXxnwNAfoK7yh0C2ibLpImpqogk5xSrZwcseyOj4CZ m2xSDboTRgT+ipAHlRmrWq9X8TbCNYqVn8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefvddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Jun 2023 09:30:18 -0400 (EDT) From: Thomas Monjalon To: Kumara Parameshwaran Cc: jiayu.hu@intel.com, dev@dpdk.org Subject: Re: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6 Date: Mon, 19 Jun 2023 15:30:16 +0200 Message-ID: <2885771.e9J7NaK4W3@thomas> In-Reply-To: <20230615062028.22773-1-kumaraparamesh92@gmail.com> References: <20221020181425.48006-1-kumaraparmesh92@gmail.com> <20230615062028.22773-1-kumaraparamesh92@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/06/2023 08:20, Kumara Parameshwaran: > The patch adds GRO support for TCP/ipv6 packets. This does not > include the support for vxlan, udp ipv6 packets. > > Signed-off-by: Kumara Parameshwaran > --- > lib/gro/gro_tcp.h | 187 ++++++++++++ > lib/gro/gro_tcp4.c | 177 +++--------- > lib/gro/gro_tcp4.h | 170 +---------- > lib/gro/gro_tcp6.c | 268 ++++++++++++++++++ > lib/gro/gro_tcp6.h | 160 +++++++++++ > lib/gro/gro_tcp_internal.h | 128 +++++++++ > lib/gro/gro_vxlan_tcp4.c | 22 +- > lib/gro/gro_vxlan_tcp4.h | 2 +- > lib/gro/meson.build | 1 + > lib/gro/rte_gro.c | 83 +++++- > lib/gro/rte_gro.h | 3 + Please would it be possible to have 2 patches: - first would move IPv4 code in a new file (without any other change) - second would add IPv6 support It would allow to see more clearly what is changed for IPv6. Thanks