From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 850EB7E75 for ; Thu, 4 Dec 2014 11:48:54 +0100 (CET) Received: by mail-wi0-f181.google.com with SMTP id r20so27422138wiv.2 for ; Thu, 04 Dec 2014 02:48:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=XEAJfPkm6nwPdF0cobCa9H6P33VaaaLGBymdqzDbBBQ=; b=czlCyWfkMGQqSl9VqB7LqN/PGUG93FLHlyhck9k9wr1yyBLm6Dlwm57vKyS2Cz56sw 9clNN3e1uhRK95Mg3OOphw2jt7TQ0e3GVYxooVHIeQD0PAVIqWgeyyLJ7lKNinY2ue9w gKF+fe82O1BC3WFbxeveFHhtwFMB4VUlsKy6g1jZk/9cLYO3+9RCLbl2FhRBunwcS7ui XrpxDWq3WK7GwOjwV7uxMmfuRmvAFBXDVbuJqLVtov35/k8P2gN23ZAIdFjQZTVOxDMs V2/k50Jga40yRtv+7Nkm+dYO8wdQ8pnj0ODAAkcjs//0kDUHf/lVPvhoHcfiRhEKQe5I jZAw== X-Gm-Message-State: ALoCoQksIAwkBIK8QsUVLUf0pFLWGjRCACUA4wGTLlo784ZVzatyAWpL8rOHJFT3tHbD+9RxZJKU X-Received: by 10.194.161.202 with SMTP id xu10mr15090595wjb.4.1417690134360; Thu, 04 Dec 2014 02:48:54 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w10sm39972849wje.10.2014.12.04.02.48.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Dec 2014 02:48:53 -0800 (PST) From: Thomas Monjalon To: "Sujith Sankar (ssujith)" Date: Thu, 04 Dec 2014 11:48:29 +0100 Message-ID: <2887963.q9hPn3S3sv@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] enic: fix warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 10:48:54 -0000 2014-12-04 10:29, Sujith Sankar: > > On 02/12/14 8:29 pm, "Thomas Monjalon" wrote: > > >A lot of warnings were not seen because $(WERROR_FLAGS) was not set > >in the Makefile. But they appear with toolchains that enforce more checks. > > > >-Wno-deprecated seems useless. > >-Wno-strict-aliasing is added to avoid false positives. > > > >This patch cleans up unused variable, unused functions, wrong types, > >static declarations, etc. A lot of functions have unused parameters; > >it suggests that more clean-up could be needed. > > > >Signed-off-by: Thomas Monjalon > >--- > > lib/librte_pmd_enic/Makefile | 3 +- > > lib/librte_pmd_enic/enic.h | 4 +- > > lib/librte_pmd_enic/enic_ethdev.c | 20 ++++----- > > Thomas, the name of this file got modified. It was enic_etherdev.c in my > submission. > Any idea how this happened? I do not remember seeing a request for this. Yes, sorry I forgot to request it. I renamed the file to be consistent with other drivers. Everywhere in DPDK we talk about ethdev for device operations, not etherdev. -- Thomas