From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Usman Tanveer <usman.tanveer@emumba.com>,
Huisong Li <lihuisong@huawei.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Gargi Sau <gargi.sau@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com
Subject: Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()
Date: Sun, 26 Jun 2022 23:16:14 +0200 [thread overview]
Message-ID: <28911775.czjnFlTdjD@thomas> (raw)
In-Reply-To: <20220527064244.10224-1-usman.tanveer@emumba.com>
27/05/2022 08:42, Usman Tanveer:
> There is a call to rte_eth_dev_stop() in rte_ethtool_net_open()
> due to which user gets misleading message upon first open/start call.
> It says that the
> device is already stopped, which should not be the case. This patch
> removes rte_eth_dev_stop() from rte_ethtool_net_open().
Why was it there?
Any opinion? Is it safe to remove?
> int
> rte_ethtool_net_open(uint16_t port_id)
> {
> - int ret;
> -
> - ret = rte_eth_dev_stop(port_id);
> - if (ret != 0)
> - return ret;
> -
> return rte_eth_dev_start(port_id);
> }
next prev parent reply other threads:[~2022-06-26 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 6:42 Usman Tanveer
2022-06-03 11:02 ` Usman Tanveer
2022-06-26 21:16 ` Thomas Monjalon [this message]
2022-07-06 9:49 ` Usman Tanveer
2022-08-18 10:18 ` Usman Tanveer
2023-07-03 22:31 ` Stephen Hemminger
2023-07-06 16:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28911775.czjnFlTdjD@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=gargi.sau@intel.com \
--cc=lihuisong@huawei.com \
--cc=qiming.yang@intel.com \
--cc=usman.tanveer@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).