From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D5D40A0548;
Tue, 20 Apr 2021 16:33:25 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 51AFF41749;
Tue, 20 Apr 2021 16:33:25 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 523F141735
for <dev@dpdk.org>; Tue, 20 Apr 2021 16:33:24 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id F06805C023F;
Tue, 20 Apr 2021 10:33:23 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Tue, 20 Apr 2021 10:33:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
uzHyQuy9Cn2ZHmTEmUfYpgvxam7OhuatrWBPwgutyx8=; b=beOvbkQIELDhg01U
2rrq3PugU5xRfYHAnMHFfwhKE+m/7Zg8E3zj0bQ8lV/3MA/3mj6v5o2YNhgPIEOz
COuf+2RKfgyU1clveBxcepiyuyUfWpPRxmiSy2EUy2FJqoDLXZMRQJjSXyp5lVm0
u6V8hI3AkWZHaSVqQYq+H3Hn6biKtVbjmRzrxjn99to0mtfYy5DJHzEDFIEpIbv1
pjtUYeduTkCm69OKFxrorClkYpH2ivrTmGnnyxP7yhgJwclR23lylVlGv+zSrXdX
2ipaCoSy33tH1oitu9v4/8Kxa/X5jDrT8+XwV5kkzVE/Wt60gR1fc8MtYFUW1voy
6SZtJg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=uzHyQuy9Cn2ZHmTEmUfYpgvxam7OhuatrWBPwguty
x8=; b=bY1oE/y1v6X+YYaoKT6u3qRpuE+VKo9sHFqvP+FC3My37MUzEvWRIhgwB
kcQcCZvaUPTU0c98l5tq94rQxiP8AGTR4PW5gkbVNL2MV/tKYU+jR01IAiJCxCW5
xrazAThEMJsoh0ka9YN+j9IgtKy8sxNZIeniyTAYoPNDGudC4hiabWORLAO6+1uS
tHTiweGjGD6he6E+UlrQUu6nD9vWOAA2/V4pPZYweXjal5NkBPoonP0/MnTBi1Cl
biTo6BON0tZU8ldR0tpUavbE/JywPs4EAiiYtgf3Mgk2GeZHUOhpfGQHBBFCeA4K
wk9Pq3a12oRNE2qpdYw5fMonBYDDw==
X-ME-Sender: <xms:MuZ-YLcoXbfxZdo4HZsPdlp8jwMwo3fhAvwY7HQxIM4OFAhp8NcJGg>
<xme:MuZ-YBPc6EeoDrTx6yTRwFLUlAecjdv7JO_5Y_hACFnCd5BwiycNDucgQ5HKs9bQl
NMHjwnQfKqK2h5JMw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtiedgjeelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:MuZ-YEgewyb1CcoiQRZl5Qf5_CqPP7ycbPHkGnj3aJWvRf4HXx1NBQ>
<xmx:MuZ-YM8AjG3KhJsYtP9l3lin0Y2-N8tej3_AUSDbib7TjtCFIc6zOg>
<xmx:MuZ-YHsWbup15L_oWyhA0qxPp0P_XUw4jfmtP09eBRkFNyGmsfnSmA>
<xmx:M-Z-YHIb7jispzXL3118lC3icI2eMg0M9rf5p-zcBEnbs9K7BDwPGg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 9A21724005E;
Tue, 20 Apr 2021 10:33:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>, Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,
stephen@networkplumber.org
Date: Tue, 20 Apr 2021 16:33:20 +0200
Message-ID: <2893662.goZOdA47Lo@thomas>
In-Reply-To: <a2222d63-0d7f-f889-0381-27e34c8962b3@redhat.com>
References: <1618046334-39857-1-git-send-email-humin29@huawei.com>
<4438095.zrIcpuxssK@thomas> <a2222d63-0d7f-f889-0381-27e34c8962b3@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
20/04/2021 16:20, Kevin Traynor:
> On 20/04/2021 11:04, Thomas Monjalon wrote:
> > 17/04/2021 09:39, Min Hu (Connor):
> >> + if (eth_link == NULL) {
> >> + RTE_ETHDEV_LOG(ERR,
> >> + "Cannot get nowait ethdev port %u for NULL link\n",
> >> + port_id);
> >
> > "nowait ethdev" is not correct.
> > I think you can just remove "nowait".
>
> The 'nowait' was just to distinguish from the otherwise identical
> message in rte_eth_link_get(). Probably it can be some way better worded.
Given they are alternative functions,
I think it is OK to have the same message.
We should not be lost in the code too much when looking for it.