From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9286F1B280 for ; Thu, 21 Dec 2017 14:38:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 05:38:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,435,1508828400"; d="scan'208";a="14175952" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 21 Dec 2017 05:38:27 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Dec 2017 05:38:27 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.21]) by FMSMSX109.amr.corp.intel.com ([169.254.15.83]) with mapi id 14.03.0319.002; Thu, 21 Dec 2017 05:38:26 -0800 From: "Wiles, Keith" To: "Varghese, Vipin" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Patel, Amol" , "Hunt, David" , "Jain, Deepak K" Thread-Topic: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user Thread-Index: AQHTekygZR/7i5MEiUehZjO86ZVWSqNOU3UA Date: Thu, 21 Dec 2017 13:38:25 +0000 Message-ID: <2893AEFC-6FD7-4D05-AB5B-F2AC018D1390@intel.com> References: <1513875200-5061-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1513875200-5061-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.0.10] Content-Type: text/plain; charset="us-ascii" Content-ID: <4A74D88CCB43614CBF20E0B191829C92@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 13:38:31 -0000 > On Dec 21, 2017, at 10:53 AM, Vipin Varghese w= rote: >=20 > TAP speed is passed as user argument, but never set to interface. > New logic brings speed get and set to LOCAL and REMOTE interfaces. >=20 > Updated the default PMD speeed to 10M as per Linux Kernel default > value. The problem in setting the link speed to 10M is that TAP will not limit its= traffic to 10M. Applications like pktgen and others use the Link speed to = calculate the bit rate, which will be broken now. I would suggest making the default value 10G or 40G instead as CPU speeds w= ill continue to increase. Forcing someone to always add the link speed seem= s a bit much when we know the systems can send/receive much higher then 10M= , which is the reason 10G was picked. Please set the default back to 10G or= some much higher number. >=20 > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 185 +++++++++++++++++++++++++++++++++++++= ++++- > 1 file changed, 182 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 6b27679..7238504 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -62,6 +62,8 @@ > #include > #include > #include > +#include > +#include >=20 Regards, Keith