DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v4] lib/power: remove set env deprecation notice
Date: Tue, 03 Nov 2020 21:46:05 +0100
Message-ID: <2897228.yid56MYTPc@thomas> (raw)
In-Reply-To: <20201027132413.23116-1-david.hunt@intel.com>

27/10/2020 14:24, David Hunt:
> Remove notice announcing an already-implemented change.
> In 19.05, rte_power_set_env was changed to return -1 in cases where
> the envorinment was already set up, and for the same release, a
> deprecation notice was added for the following commit:
> 'commit 5a5f3178d4a8 ("power: return error when environment already set")'
> This patch removes that notice.
> The API change was tested by calling rte_power_set_env twice. The first
> call succeeded, and the second call failed, as expected.
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> v1 initial version (with typo in the title)
> v2 fix typo but forgot --in-reply-to
> v3 add -in-reply-to
> v4 add in version info, and cc stable in case it needs to be backported
> Note: CC'ing stable in case the deprecation notice should also be removed
> from 19.11. It looks to me like the patch making the change and the patch
> adding the notice were both added in 19.11, so the notice is no longer
> needed in that verion. I didn't add a Fixes line to this patch as I believe
> the notice was correct, just adding both fix and notice in the same version
> was not strictly the right thing to have done at the time.

The Fixes: line must reference the commit which did the API change
without removing the notice.

Cc: stable@dpdk.org must be below the Fixes line.

  reply	other threads:[~2020-11-03 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 12:49 [dpdk-dev] [PATCH v2] " David Hunt
2020-10-27 12:52 ` [dpdk-dev] [PATCH v3] " David Hunt
2020-10-27 13:24   ` [dpdk-dev] [PATCH v4] " David Hunt
2020-11-03 20:46     ` Thomas Monjalon [this message]
2020-11-04  9:28     ` [dpdk-dev] [PATCH v5] " David Hunt
2020-11-04 20:10       ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2897228.yid56MYTPc@thomas \
    --to=thomas@monjalon.net \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git