From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BC16E1B685 for ; Tue, 6 Feb 2018 18:46:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51B7A21124; Tue, 6 Feb 2018 12:46:18 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 06 Feb 2018 12:46:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=6EjXasa0TuBMH7JvERHxdjvQd9 sA5m7tXTmjEkRSFDQ=; b=mwuCZ8YfQWP+PAzLt9rA3dE/fdzW6R4p9iLsAwlAqE 4iJbWTmub7UckTWt9UXEgdPCrLmkS+JzTpkvPukL51X0WzrQrY8QDoZS8Roy1XzM cU1+oy8gsD5jV42LgW2bUVL3IDXWxGRIqOYwneTkvE3t84PguQh2OU0bAUIt9XMO o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=6EjXas a0TuBMH7JvERHxdjvQd9sA5m7tXTmjEkRSFDQ=; b=jiCsGSl7YaTeA4G55YLG4a EErG+d01x8cchyCtakueJ2C/FXBfmi1c1O6mYM5zrke7QZ2HMGRSLMBuMTONaewi uGuys4nVinGkz7H3rutPD5D88KxDXB5WSk+927TtLnszDplGbT2Uu6yLwAHYKxRw 1xEjZPv/bWf6oITrWwQ7pS4ySIYBNoYX5+mBFufaM8et/Ksz7r4re1LsljV6F/ef +JEa+ILJNG++GV4FOuRSyRzFx5dU72RefS7uh8PaDbraiixTOxqOAF2Y4rztFowH GUinGo25gU5gbL9tqxEERMmX3dPYck+nc6Ko2hKXskFJ1G2vVG/M91fSQ3JxAp2A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F241A24713; Tue, 6 Feb 2018 12:46:17 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 06 Feb 2018 18:46:14 +0100 Message-ID: <2897371.3Us8B8FbjR@xps> In-Reply-To: <20180206160659.87323-1-bruce.richardson@intel.com> References: <20180206160659.87323-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ether: fix incorrect stats query for lowest xstat id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 17:46:18 -0000 06/02/2018 17:06, Bruce Richardson: > When querying either the name or the value of a stat using the xstats > APIs, a check is done to see if the regular stats API or the xstats APIs > for the driver need to be used. However, the id of the stat requested is > checked to see if it is greater than the number of basic stats, rather > than checking for greater-or-equal, meaning that the xstat with the lowest > id gets incorrectly treated as a basic stat. > > This problem manifests itself when you call proc_info using "--xstats-id" > for the first xstat, you get no name of the stat printed, and a random(ish) > stat value. > > Fixes: 4773152f850b ("ethdev: optimize xstats by ids APIs") > > Signed-off-by: Bruce Richardson Applied, thanks It looks like the stats functions are the most reworked and fixed. It is a no-end story. According to git statistics, it is probably the most complicate code of DPDK :) I am thinking about being more conservative and do not accept any new change in these rocket science functions ;)