From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 22533DED for ; Tue, 1 May 2018 17:59:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8365C21CAD; Tue, 1 May 2018 11:59:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 01 May 2018 11:59:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CrNkMhOOoJ9VtgNs1ZVM0UESTn zRGuquu2HJlu27vTs=; b=De/H7UZLnrDrza0N28YJOYLAQYYMXgZ0g1JvtmF9lX 0Eu7JCDlwPGKxajISB22xWXvnyT7l9WcZAE3KeHNhvFj+fsgPFluuZoG2PSZjbVQ j8n83nLIrpBOxrHpfM0odM8AeQH133xdo5hR2PM6BHQ4fPTXotbyngHUcCF8WsXp U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CrNkMh OOoJ9VtgNs1ZVM0UESTnzRGuquu2HJlu27vTs=; b=JgjYfxFAvauC9vpTN5rp5M Ku7e8O6mmeVwBEyPKpZO4YF4OmyD7BtmbFeoIKNMYBTFOkI3xBwkTTZcSLpAK85U g2cZ27rxaQ7RwEW09x9rBdPV5Bq3J05S30WCWUR1waM0lkCYAJpYy/I7YuqthmAl Hi8NOh2ueYIc6HzEH8tYa27dHtLcBSXgJZWejZ+nohpYL3r5f7eIhGJpLhzvfmaV p79zt3wP7yN07q2BTSsFtbZZvYfeYnlat5OrbTpdjh17hsQ7jzBeYHhp/4R4/4Qd LwUfTEivLb6waD4ehqyWCKqqVExnDIXEuPyZ6alPdigvDszjjgi2VTNTQewv4V7g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C8CD2E444A; Tue, 1 May 2018 11:59:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, xuemingl@mellanox.com Date: Tue, 01 May 2018 17:59:33 +0200 Message-ID: <2898570.6ZVCGMQ03T@xps> In-Reply-To: <5512562.2HDlAgTDzM@xps> References: <20180501133343.125260-1-ferruh.yigit@intel.com> <5512562.2HDlAgTDzM@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 15:59:36 -0000 01/05/2018 17:30, Thomas Monjalon: > 01/05/2018 15:33, Ferruh Yigit: > > Many sample applications fail because of > > dev_info.flow_type_rss_offloads check in rte_eth_dev_configure() > > > > The sample applications need to be fixed/updated before returning error > > on rte_eth_dev_configure() > > > > This patch keeps the error log but removes returning error. > > > > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") > > Cc: xuemingl@mellanox.com > > > > Signed-off-by: Ferruh Yigit > > Applied, thanks I've also removed the error return for rte_eth_dev_rss_hash_update which was introduced by the same above patch. Signed-off-by: Thomas Monjalon