From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode
Date: Thu, 03 Dec 2015 00:14:27 +0100 [thread overview]
Message-ID: <2898846.N9SNaCC8LE@xps13> (raw)
In-Reply-To: <1449059922-10976-1-git-send-email-christian.ehrhardt@canonical.com>
2015-12-02 13:38, Christian Ehrhardt:
> Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was
> enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html).
> Now the underlying issue is rather simple, the xen code needs libxenstore.
> But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was
> disabled.
> While it is correct to create the DPDK sublib linking only in the
> RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked
> libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled.
[...]
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -113,6 +113,7 @@ endif # ! CONFIG_RTE_BUILD_SHARED_LIBS
> _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz
>
> _LDLIBS-y += --start-group
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore
Why is it moved after --start-group and not above as other dependencies?
> ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
next prev parent reply other threads:[~2015-12-02 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 12:38 Christian Ehrhardt
2015-12-02 23:14 ` Thomas Monjalon [this message]
2015-12-03 6:56 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2898846.N9SNaCC8LE@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).