From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 261E95913 for ; Thu, 3 Dec 2015 00:15:38 +0100 (CET) Received: by wmww144 with SMTP id w144so78040505wmw.0 for ; Wed, 02 Dec 2015 15:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=wiDCybOO99+jyIboq41ZtPNrOGa8TSb4oD6i5dQavbY=; b=Z/x30CsEvOJV444WRLxjhnFuYvZgjn7rcCNE3CmW5jTkCJWojfLLr38wX3aFUdFOg/ njxA3GswuaENfReQ+DleHbvcdEWGa8cYdJ0SUwPqivrg5t0xnCQWSIaG930m+KW2EgTV QQ/sbL32TNUvW6jeH/2o+KtnuzH+PMDa2P7IwA51vWXkMvB+AAIbBVadtTfOys5xl41u SzKQs8iucgiaO+VkcteqxR6Bze9LR87NKzqHUWo+pwPCg5fq+PpRi4r4lMmVAShKqvvf R8+AATejgnRzwTIfSqcmX3SoZ/R687pMbRBv2rK52XidcGyjfHOBKrwXXPdkxFKmI8jW 4tVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=wiDCybOO99+jyIboq41ZtPNrOGa8TSb4oD6i5dQavbY=; b=DF/ASSCyqK2jckSExbFe7EmDe0nWyds5iupwYMEYaZtuMawDEnZsFaDsU6dqHkqyf9 kU46Qw2/AcJw23dTriBbirXweF7Xnd5ah6ZMWYWlWgInzQIIiPAvjm2joy2kWLG84B8i xca7OET41YohGw3h1l1vgnSnC9r9kizpgqHdgFrU080HQmYwxOn/+EfLSLzTJMGc/l2x OUuPs7by/B/twQoAB6He/JMiDV6oMN3Jno3hWBqHPin4zELAaVtxFFYYjpwdXP3/8CQN VZPMpZP3BVw1sG1100K4udKWt4c1I4Q4UTto8gAUlBzCzu1REpbUwfprnTSueuk1Y7AS 4ANw== X-Gm-Message-State: ALoCoQm8B3SJsFSpZ3vi4foHeeq9cEZcUmDj5hLx06k+KIxdM2A1AxmLCXQh7iNicG0/yZ59icjv X-Received: by 10.28.101.65 with SMTP id z62mr8975456wmb.84.1449098137945; Wed, 02 Dec 2015 15:15:37 -0800 (PST) Received: from xps13.localnet ([93.158.56.129]) by smtp.gmail.com with ESMTPSA id n7sm5200782wmf.21.2015.12.02.15.15.36 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Dec 2015 15:15:37 -0800 (PST) From: Thomas Monjalon To: Christian Ehrhardt Date: Thu, 03 Dec 2015 00:14:27 +0100 Message-ID: <2898846.N9SNaCC8LE@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449059922-10976-1-git-send-email-christian.ehrhardt@canonical.com> References: <1449059922-10976-1-git-send-email-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 23:15:38 -0000 2015-12-02 13:38, Christian Ehrhardt: > Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was > enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). > Now the underlying issue is rather simple, the xen code needs libxenstore. > But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was > disabled. > While it is correct to create the DPDK sublib linking only in the > RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked > libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled. [...] > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -113,6 +113,7 @@ endif # ! CONFIG_RTE_BUILD_SHARED_LIBS > _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz > > _LDLIBS-y += --start-group > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore Why is it moved after --start-group and not above as other dependencies? > ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)