From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15577A0A02; Thu, 25 Mar 2021 09:46:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F3364067B; Thu, 25 Mar 2021 09:46:09 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 726CF40147; Thu, 25 Mar 2021 09:46:07 +0100 (CET) IronPort-SDR: GcBrIdYe89Gaov5oweMaL0h2jXAUyP8RFIJGcesds2qjPzecsI6S+SFY8u2gVUTfpKyLJ9FBlx 0aYsUnnv2KRQ== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="177998229" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="177998229" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 01:46:05 -0700 IronPort-SDR: zFzZRnPCLcej0x30XBnVKUZU8nd8lnHe7mfOzdzPTpdvCAayShL208ZTS3Rk8f9n3Z0hV3qGiN 7JRaQwYPII6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="409270013" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 25 Mar 2021 01:46:05 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 01:46:04 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 16:46:02 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Thu, 25 Mar 2021 16:46:02 +0800 From: "Zhang, Qi Z" To: Xiaozhen Ban , "Guo, Jia" , "Wang, Haiyue" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/e1000: fix filter control return value Thread-Index: AQHXGyAJYVBZjFvw10qPA+lKoNHYNqqJG5wAgAA+nQCAANRlgIAKO5eA Date: Thu, 25 Mar 2021 08:46:02 +0000 Message-ID: <289fcebe24c8414bb28c949ef87dd349@intel.com> References: <20210319040817.64143-1-benhaz1024@gmail.com> In-Reply-To: <20210319040817.64143-1-benhaz1024@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Xiaozhen Ban > Sent: Friday, March 19, 2021 12:08 PM > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return valu= e >=20 > > > -----Original Message----- > > > From: Xiaozhen Ban > > > Sent: Thursday, March 18, 2021 19:44 > > > To: Guo, Jia ; Wang, Haiyue > > intel.com> > > > Cc: dev at dpdk.org; stable at dpdk.org > > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value > > > > > > OK, but I think this bug affects all stable release about 6 years bef= ore today. >=20 > > I don't think so, since it is PMD internal ops, the real API 'rte_flow_= ops_get' > > always use RTE_ETH_FILTER_GENERIC. ;-) >=20 > eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application= developer > know how to use the parameter filter_type correctly, it's OK. > otherwise he will get rte_eth_dev_filter_ctrl() return value is success b= ut > actually is failed. After check with Haiyue, we think the patch is still needed for LTS <=3D 19= .11, so Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi