From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 12E6D1B6C2 for ; Wed, 4 Oct 2017 19:26:34 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 10:26:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,478,1500966000"; d="scan'208";a="906737724" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.26]) ([10.241.225.26]) by FMSMGA003.fm.intel.com with ESMTP; 04 Oct 2017 10:26:23 -0700 To: Pascal Mazon , Matan Azrad Cc: dev@dpdk.org References: <1507042556-9839-1-git-send-email-matan@mellanox.com> <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> From: Ferruh Yigit Message-ID: <28a38c08-efac-3a4f-24d8-028dd35749db@intel.com> Date: Wed, 4 Oct 2017 18:26:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 17:26:35 -0000 On 10/4/2017 9:15 AM, Pascal Mazon wrote: > Hi, > > I'm surprised there's only one place in the file with indent problem, > but I'm ok with the patch otherwise. > > Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in > patch 2/2, right? I wasn't sure about getting the patch that fixes only syntax in one place. Good to have proper syntax but a commit for this looked like overkill to me. So I was suggesting keep it as it is and fix syntax when that piece of code updated later. But you are the maintainer of the driver, if you have strong opinion to get it, sure I can. Thanks, ferruh > > Best regards, > Pascal > > On 04/10/2017 00:07, Ferruh Yigit wrote: >> On 10/3/2017 3:55 PM, Matan Azrad wrote: >>> Missed 4 spaces were added after break if line. >>> >>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >> What do you think fixing this when that code has been touched next time? >> >>> Signed-off-by: Matan Azrad >>> --- >>> drivers/net/tap/tap_flow.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c >>> index eefa868..aa33960 100644 >>> --- a/drivers/net/tap/tap_flow.c >>> +++ b/drivers/net/tap/tap_flow.c >>> @@ -1093,7 +1093,7 @@ struct tap_flow_items { >>> goto exit_action_not_supported; >>> action = 1; >>> if (!queue || >>> - (queue->index > pmd->dev->data->nb_rx_queues - 1)) >>> + (queue->index > pmd->dev->data->nb_rx_queues - 1)) >>> goto exit_action_not_supported; >>> if (flow) >>> err = add_action_skbedit(flow, queue->index); >>> >