Re: [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for high frequency cores

["Hunt, David" <david.hunt@intel.com>]

Hi Anatoly,

On 1/4/2019 4:43 PM, Burakov, Anatoly wrote:
> On 01-Apr-19 4:30 PM, David Hunt wrote:
>> This patch adds a new bit in the capabilities mask that's returned by
>> rte_power_get_capabilities(), allowing application to query which cores
>> have the higher frequencies, and can then pin the workloads accordingly.
>>
>> Returned Bits:
>>   0 - Turbo Boost enabled
>>   1 - Higher core base_frequency
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>
> <snip>
>
>>       /* Add MSR read to detect turbo status */
>>         if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) 
>> < 0)
>> @@ -179,6 +207,14 @@ power_init_for_setting_freq(struct 
>> pstate_power_info *pi)
>>         pi->non_turbo_max_ratio = max_non_turbo;
>>   +    /*Add the compare for base frequency  */
>
> The comment here looks meaningless, and needs to be reworded to 
> explain why this is done, not what is done.
>
> Otherwise,
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
>

OK, Thanks for that. I'll push a v5 shortly, including your Reviewed-by tag.

Rgds,
Dave.