From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5761A2C0C for ; Tue, 18 Oct 2016 10:13:57 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF0A0C04B30F; Tue, 18 Oct 2016 08:13:56 +0000 (UTC) Received: from [10.36.5.202] (vpn1-5-202.ams2.redhat.com [10.36.5.202]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9I8DsU2006693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2016 04:13:55 -0400 To: Yuanhan Liu References: <1476717036-17399-1-git-send-email-maxime.coquelin@redhat.com> <67f1efc4-e476-1f5c-137a-1e36aceb73bf@redhat.com> <20161018081221.GH16751@yliu-dev.sh.intel.com> Cc: dev@dpdk.org, zhihong.wang@intel.com, ciara.loftus@intel.com From: Maxime Coquelin Message-ID: <28badf80-7915-6b99-7632-77772130bc4d@redhat.com> Date: Tue, 18 Oct 2016 10:13:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161018081221.GH16751@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 18 Oct 2016 08:13:56 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: disable indirect descriptors feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 08:13:57 -0000 On 10/18/2016 10:12 AM, Yuanhan Liu wrote: > On Tue, Oct 18, 2016 at 09:04:44AM +0200, Maxime Coquelin wrote: >> Hi Yuanhan, >> >> On 10/17/2016 05:10 PM, Maxime Coquelin wrote: >>> Commit 2304dd73d287 ("vhost: support indirect Tx descriptors") >>> adds support for indirect descriptors for Tx, but not for Rx. >>> >>> The problem is that it does not work with windows guests, which >>> uses indirect descriptors for the Rx, and also with Linux guests >>> when using kernel driver with mergeable buffers feature disabled. >>> >>> While indirect descriptors support is also added to the Rx path, >>> let's disable the feature. >>> >>> Reported-by: Zhihong Wang >>> Reported-by: Ciara Loftus >>> Cc: Yuanhan Liu >>> Signed-off-by: Maxime Coquelin >>> --- >>> lib/librte_vhost/vhost.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c >>> index 469117a..f5f8f92 100644 >>> --- a/lib/librte_vhost/vhost.c >>> +++ b/lib/librte_vhost/vhost.c >>> @@ -65,8 +65,7 @@ >>> (1ULL << VIRTIO_NET_F_CSUM) | \ >>> (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ >>> (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ >>> - (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \ >>> - (1ULL << VIRTIO_RING_F_INDIRECT_DESC)) >>> + (1ULL << VIRTIO_NET_F_GUEST_TSO6)) >>> >>> uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES; >> >> I have implemented Indirect descs for the Rx path yesterday. >> It deserves more testing, but early tests show it fix the issues found >> with VIRTIO_RING_F_INDIRECT_DESC (both with and without mergeable >> buffers). >> >> >> Thanks to Zhihong series you reworked, the changes to be done for >> mergeable buffers case is greatly simplified. >> I'll send the series later today. > > Do you mean the v6 from Zhihong? Unluckily, it will not be merged. That > series has been simplified to not rewrite the enqueue from scratch. See > V7. No, I meant the v7. > > For this patch, I think you should also update (or remove?) the related > section in the release note. Yes, sure. Thanks, Maxime