From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DFD843F56; Tue, 30 Apr 2024 22:13:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DDBC40262; Tue, 30 Apr 2024 22:13:51 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id B26654025C for ; Tue, 30 Apr 2024 22:13:49 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 786B88521 for ; Tue, 30 Apr 2024 22:13:49 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 6C86B84B2; Tue, 30 Apr 2024 22:13:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.3 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E33048598; Tue, 30 Apr 2024 22:13:47 +0200 (CEST) Message-ID: <28dc7dc7-eb26-4405-9d80-9d8ec10f88b2@lysator.liu.se> Date: Tue, 30 Apr 2024 22:13:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Run unit tests with C++ too To: Patrick Robb Cc: "dev@dpdk.org" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "Richardson, Bruce" References: <4d5510d1-bdc6-43de-abbc-749eaa3c75a4@lysator.liu.se> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-04-30 15:52, Patrick Robb wrote: > > > On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom > wrote: > > It would be great if the unit test suite (app/test/*) was compiled (and > run) using a C++ (C++11) compiler as well. At least, if such is > available. > > > Sure, the UNH Lab can try this. > > > With the current state of affairs, header file macros or functions are > not verified to be functional (or even valid) C++. > > "C is a subset of C++", which was never true, is becoming less and > less so. > > If all unit tests aren't valid C++, maybe one could start with an "opt > in" model. > > > Okay, so basically run the fast-test suite, record all that don't pass, > submit a bugzilla ticket stating which unit tests are not valid on a > certain c++ compiler, then bring CI Testing online using the valid > subset of fast-tests. This should work. > Sounds good. Just to be clear: the above includes extending the DPDK build system to build the app/test/dpdk-test binary in two versions: one C and one C++, so that anyone can run the C++ tests locally as well. Correct? > > A drawback of this is that the unit tests need to be both valid C and > valid C++. >